Remove vestigial account-info and Partners codegen plumbing#8115
Open
isaacroldan wants to merge 1 commit into
Open
Conversation
This was referenced Jul 16, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
isaacroldan
force-pushed
the
partners-cleanup/06-drop-vestigial-account-info
branch
from
July 16, 2026 15:11
b01ff7b to
5f5c49d
Compare
Follow-up cleanup now that PartnersClient is reduced to the migration surface. currentAccountInfo was a Partners-era method. AppManagement implements it as a throwing stub, and its only caller (fetchOrganizations, via fetchCurrentAccountInformation) swallowed the throw and fell back to an "unknown account" in the "No Organization found" error. Switch that caller to session.accountInfo -- which AppManagement already populates and which the sibling fetchOrgFromId already uses -- so the error now names the real account. Then drop currentAccountInfo from the interface, the AppManagement stub, and the test double, and delete the orphaned partner-account-info service plus its generated current-account-info document. With partner-account-info gone, its account-info cache in app-conf-store had no remaining callers, so delete that file and its test. partnersRequestDoc had no remaining callers after PartnersClient stopped using it; remove the dead cli-kit export and the imports it exclusively pulled in. The Partners typed-document codegen no longer has any operations: remove the partners project from graphql.config.ts and its nx targets, delete the orphaned generated types, and drop the Partners schema from the fetch script. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
partners-cleanup/06-drop-vestigial-account-info
branch
from
July 16, 2026 15:36
5f5c49d to
a520fee
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/api/partners.d.ts@@ -1,7 +1,5 @@
import { GraphQLVariables, GraphQLResponse, CacheOptions, UnauthorizedHandler } from './graphql.js';
import { RequestModeInput } from '../http.js';
-import { Variables } from 'graphql-request';
-import { TypedDocumentNode } from '@graphql-typed-document-node/core';
/**
* Executes a GraphQL query against the Partners API.
*
@@ -14,21 +12,6 @@ import { TypedDocumentNode } from '@graphql-typed-document-node/core';
* @returns The response of the query of generic type <T>.
*/
export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
-export declare const generateFetchAppLogUrl: (cursor?: string, filters?: {
- status?: string;
- source?: string;
-}) => Promise<string>;
-/**
- * Executes a GraphQL query against the Partners API. Uses typed documents.
- *
- * @param query - GraphQL query to execute.
- * @param token - Partners token.
- * @param variables - GraphQL variables to pass to the query.
- * @param preferredBehaviour - Preferred behaviour for the request.
- * @param unauthorizedHandler - Optional handler for unauthorized requests.
- * @returns The response of the query of generic type <TResult>.
- */
-export declare function partnersRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables>, token: string, variables?: TVariables, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<TResult>;
/**
* Sets the next deprecation date from [GraphQL response extensions](https://www.apollographql.com/docs/resources/graphql-glossary/#extensions)
* if objects contain a (ISO 8601-formatted string).
|
isaacroldan
marked this pull request as ready for review
July 16, 2026 15:53
isaacroldan
changed the base branch from
partners-cleanup/05-trim-dead-graphql-consts
to
graphite-base/8115
July 16, 2026 16:08
isaacroldan
changed the base branch from
graphite-base/8115
to
partners-cleanup/03-shrink-partners-client
July 16, 2026 16:08
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Final sweep of vestigial Partners / account-info plumbing left behind once
PartnersClientwas reduced to the migration surface. Includes one small user-facing fix.WHAT is this pull request doing?
currentAccountInfowas a Partners-era interface method.AppManagementClientimplemented it as a throwing stub, and its only caller (fetchOrganizations, viafetchCurrentAccountInformation) swallowed the throw and fell back to "an unknown account" in theNo Organization founderror. Switch that caller tosession.accountInfo— which App Management already populates and which the siblingfetchOrgFromIdalready used — so the error now names the real account. Then removecurrentAccountInfofrom the interface, the AppManagement stub, and the test double, and delete the orphanedpartner-account-infoservice and its generatedcurrent-account-infodocument.app-conf-store.ts(and its test): its account-info cache had no remaining callers oncepartner-account-infowas gone.partnersRequestDocfrom cli-kit (no remaining callers) and the imports it exclusively pulled in.partnersproject ingraphql.config.ts, its nx targets inproject.json, the orphaned generated types, and the Partners schema entry inbin/get-graphql-schemas.js.How to test your changes?
pnpm nx type-check app cli-kit+ lint pass. Behavior check: hittingNo Organization found(an account with zero organizations) now names the signed-in account instead of "an unknown account". Everything else is dead-code removal.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add