Delete orphaned partners-era GraphQL documents#8112
Closed
isaacroldan wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 16, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
the
no-changelog
4 tasks
Fourth step of the PartnersClient cleanup. These GraphQL documents were only used by the PartnersClient methods removed in the previous step, so nothing imports them anymore. Delete the 12 hand-written query/mutation files, the two generated partners operations (all-orgs, dev-stores-by-org) with their .graphql sources, and their no-inline-graphql allowlist entries. Retype the app-logs subscribe test fixture to the generated document type. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
partners-cleanup/03-shrink-partners-client
branch
from
July 16, 2026 14:45
da9696c to
dda8750
Compare
isaacroldan
force-pushed
the
partners-cleanup/04-delete-orphaned-graphql
branch
from
July 16, 2026 14:45
95d74aa to
3d33046
Compare
4 tasks
isaacroldan
changed the base branch from
partners-cleanup/03-shrink-partners-client
to
graphite-base/8112
July 16, 2026 15:11
isaacroldan
marked this pull request as ready for review
July 16, 2026 15:53
Contributor
Author
|
Folded into #8111 — the file deletions must land in the same PR as the PartnersClient shrink that orphans them (per-PR Knip check). |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After shrinking
PartnersClient, the GraphQL query/mutation documents its removed methods used are dead.WHAT is this pull request doing?
Delete 16 orphaned GraphQL files (hand-written query consts + generated typed-documents) and remove their
no-inline-graphqlknownFailuresallowlist entries:app_active_version,app_version_by_tag,create_app,find_app,find_org,find_org_basic,find_store_by_domain,generate_signed_upload_url,subscribe_to_app_logs,template_specificationsfunctions/api_schema_definition,functions/target_schema_definitionpartners/queries/{all-orgs,dev-stores-by-org}.graphqland their generatedpartners/generated/{all-orgs,dev-stores-by-org}.tsAlso drops the matching test-double stubs in
app.test-data.ts.How to test your changes?
pnpm nx type-check app+ lint pass. Codegen is glob-driven, so removing the query files leaves nothing to regenerate.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add