Extract MigrationDeveloperPlatformClient interface#8109
Open
isaacroldan wants to merge 2 commits into
Open
Conversation
First step of the PartnersClient cleanup. The legacy extension migrations (Flow, app module, UI extension) are the only production use of PartnersClient. Extract a narrow MigrationDeveloperPlatformClient interface and retype the migration call sites to it, so PartnersClient no longer needs the full DeveloperPlatformClient surface. AppManagementClient drops its three "Not implemented" migrate stubs. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
the
no-changelog
This was referenced Jul 16, 2026
Second step of the PartnersClient cleanup. createUnauthorizedHandler only uses a small slice of a developer platform client (session and unsafeRefreshToken), but was typed against the whole DeveloperPlatformClient. Narrow it to the minimal Pick subset it consumes so a client that no longer implements the full interface can still be passed. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
PartnersClientis only used in production to run the three legacy extension migrations (Flow, app module, UI extension), yet it implements the fullDeveloperPlatformClient. Before it can be reduced to a migration-only client (later in the stack), the type surface has to allow a client that implements just the migration slice.WHAT is this pull request doing?
MigrationDeveloperPlatformClientinterface (the threemigrate*methods) and retype the migration call sites (migrate-flow-extension,migrate-app-module,migrate-to-ui-extension,deploy-app-version-migrations) to it.migrate*methods fromDeveloperPlatformClient;AppManagementClientdrops its three matching "Not implemented" stubs.createUnauthorizedHandlerto aTokenRefreshableClient=Pick<DeveloperPlatformClient, 'session' | 'unsafeRefreshToken'>, so a client that no longer implements the full interface can still refresh tokens.No runtime behavior changes — this only reshapes types.
How to test your changes?
Type-only refactor.
pnpm nx type-check appand the existing test suite pass; nothing changes at runtime.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add