Trim dead partners-era GraphQL consts and cli-kit helper#8114
Closed
isaacroldan wants to merge 1 commit into
Closed
Trim dead partners-era GraphQL consts and cli-kit helper#8114isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
This was referenced Jul 16, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Final step of the PartnersClient cleanup. The PartnersClient methods removed earlier in the stack were the only users of these GraphQL query/mutation constants and of the generateFetchAppLogUrl cli-kit helper. Drop the dead constants from the shared query files (keeping the schema/variables types still used by AppManagementClient and other live code), remove generateFetchAppLogUrl, and prune the now-inert no-inline-graphql allowlist entries. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
partners-cleanup/05-trim-dead-graphql-consts
branch
from
July 16, 2026 14:45
6bfded0 to
3a4af70
Compare
isaacroldan
force-pushed
the
partners-cleanup/04-delete-orphaned-graphql
branch
from
July 16, 2026 14:45
95d74aa to
3d33046
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/api/partners.d.ts@@ -14,10 +14,6 @@ import { TypedDocumentNode } from '@graphql-typed-document-node/core';
* @returns The response of the query of generic type <T>.
*/
export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
-export declare const generateFetchAppLogUrl: (cursor?: string, filters?: {
- status?: string;
- source?: string;
-}) => Promise<string>;
/**
* Executes a GraphQL query against the Partners API. Uses typed documents.
*
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Several shared GraphQL files still export query/mutation consts that only
PartnersClientused, and cli-kit still exported a Partners-only app-logs URL helper. All are now dead.WHAT is this pull request doing?
PartnersClient-only consts from shared GraphQL files, keeping the schema/variable types still used by the App Management client:app_deploy,app_release,app_versions_diff,get_versions_list,update_urls,all_app_extension_registrations,extension_specifications, and the webhookrequest-sample/request-api-versions/request-topicsservices.generateFetchAppLogUrlfrom cli-kit'snode/api/partners(the App Management path has its own equivalent).no-inline-graphqlknownFailuresentries.No runtime behavior changes.
How to test your changes?
pnpm nx type-check app cli-kit+ lint pass.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add