Skip to content

Trim dead partners-era GraphQL consts and cli-kit helper#8114

Closed
isaacroldan wants to merge 1 commit into
partners-cleanup/04-delete-orphaned-graphqlfrom
partners-cleanup/05-trim-dead-graphql-consts
Closed

Trim dead partners-era GraphQL consts and cli-kit helper#8114
isaacroldan wants to merge 1 commit into
partners-cleanup/04-delete-orphaned-graphqlfrom
partners-cleanup/05-trim-dead-graphql-consts

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

PartnersClient cleanup — 4 of 5.

WHY are these changes introduced?

Several shared GraphQL files still export query/mutation consts that only PartnersClient used, and cli-kit still exported a Partners-only app-logs URL helper. All are now dead.

WHAT is this pull request doing?

  • Trim the dead PartnersClient-only consts from shared GraphQL files, keeping the schema/variable types still used by the App Management client: app_deploy, app_release, app_versions_diff, get_versions_list, update_urls, all_app_extension_registrations, extension_specifications, and the webhook request-sample / request-api-versions / request-topics services.
  • Remove generateFetchAppLogUrl from cli-kit's node/api/partners (the App Management path has its own equivalent).
  • Drop the corresponding no-inline-graphql knownFailures entries.

No runtime behavior changes.

How to test your changes?

pnpm nx type-check app cli-kit + lint pass.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

isaacroldan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 16, 2026
Final step of the PartnersClient cleanup. The PartnersClient methods removed
earlier in the stack were the only users of these GraphQL query/mutation
constants and of the generateFetchAppLogUrl cli-kit helper. Drop the dead
constants from the shared query files (keeping the schema/variables types still
used by AppManagementClient and other live code), remove generateFetchAppLogUrl,
and prune the now-inert no-inline-graphql allowlist entries. No behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@isaacroldan
isaacroldan force-pushed the partners-cleanup/05-trim-dead-graphql-consts branch from 6bfded0 to 3a4af70 Compare July 16, 2026 14:45
@isaacroldan
isaacroldan force-pushed the partners-cleanup/04-delete-orphaned-graphql branch from 95d74aa to 3d33046 Compare July 16, 2026 14:45
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/partners.d.ts
@@ -14,10 +14,6 @@ import { TypedDocumentNode } from '@graphql-typed-document-node/core';
  * @returns The response of the query of generic type <T>.
  */
 export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
-export declare const generateFetchAppLogUrl: (cursor?: string, filters?: {
-    status?: string;
-    source?: string;
-}) => Promise<string>;
 /**
  * Executes a GraphQL query against the Partners API. Uses typed documents.
  *

@isaacroldan
isaacroldan marked this pull request as ready for review July 16, 2026 15:53
@isaacroldan
isaacroldan requested a review from a team as a code owner July 16, 2026 15:53
@isaacroldan
isaacroldan deleted the branch partners-cleanup/04-delete-orphaned-graphql July 16, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant