fix: android consumer-rules - #145
Open
ovitrif wants to merge 14 commits into
Open
Conversation
ben-kaufman
reviewed
Aug 26, 2026
ben-kaufman
reviewed
Aug 26, 2026
ben-kaufman
reviewed
Aug 26, 2026
ovitrif
marked this pull request as draft
August 26, 2026 20:39
ovitrif
changed the title
ovitrif
changed the title
ovitrif
marked this pull request as ready for review
August 26, 2026 21:42
ben-kaufman
reviewed
Aug 26, 2026
This was referenced Aug 27, 2026
This comment was marked as resolved.
This comment was marked as resolved.
ben-kaufman
reviewed
Aug 27, 2026
This was referenced Aug 27, 2026
R8 full mode stripped @structure.FieldOrder from UniFFI structs. Keep the annotation type and annotated classes so JNA can still lay out the structs.
Ship FieldOrder and com.sun.jna.* keeps in the AAR. Library publish only checks that proguard.txt is packaged; minified-app proof is the Bitkit release build.
This reverts commit 0ae27d5.
ovitrif
force-pushed
the
fix/r8-keep-fieldorder
branch
from
August 27, 2026 17:43
303a066 to
844fa90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140
Follow-up to #139.
The Android AAR ships consumer keep rules for UniFFI/JNA so a minified app can resolve JNI names and lay out JNA structs.
Library publish packages
proguard.txtin the AAR. Minified-app R8 belongs in the consuming app.Description
com.sun.jna.*solibjnidispatchcan resolve JNI names onNative,Structure, andCallbackReference.com.sun.jna.*, includingcom.sun.jna.ptrByReference types used as UniFFI callback out-params.com.sun.jna.Structure$FieldOrderand annotatedcom.synonym.bitkitcorestruct classes, fields, and constructors.bundleReleaseAarwhen the AAR is missing a non-emptyproguard.txt.Out of scope
Preview
N/A — Android consumer keep rules only.
QA Notes
devReleaseon Pixel_10_Pro_XL (16KB) with this artifact served via mavenLocal: terms, skip intro, new wallet, home with savings and spending at ₿0. No JNI/JNA crash.com.synonym.bitkitcore.**and the app-wide FieldOrder, Structure, and Callback keeps.proguard.txtwith those consumer keep rules.Release