feat: expose watcher receive address - #147
Merged
Merged
Conversation
ben-kaufman
force-pushed
the
feat/watcher-receive-address
branch
from
August 27, 2026 14:28
de2b8bf to
4078267
Compare
This was referenced Aug 27, 2026
ovitrif
reviewed
Aug 27, 2026
ovitrif
left a comment
Collaborator
There was a problem hiding this comment.
The checked-in Python binding is stale relative to the watcher payload, and the new derivation-error branch seems to lack focused test coverage. Please check my inline comments.
ben-kaufman
force-pushed
the
feat/watcher-receive-address
branch
from
August 27, 2026 17:31
4078267 to
c1a87a2
Compare
Collaborator
|
Thanks — I’ve rebased #145 onto this branch; after #147 merged, GitHub retargeted #145 to The test fix itself did not require another binding regeneration or version bump here. #145 owns the follow-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TransactionsChangedwatcher event.AddressIndex::LastUnused, while preserving the existing watcher error event on derivation failure.Preview
N/A — generic Core API change.
QA Notes
cargo test modules::onchain::listener::tests(3 passed)cargo clippy --lib --no-deps(passed; existing repository warnings only)rustfmt --checkandgit diff --check(passed)./build_ios.sh(passed)./build_android.sh(passed, including Maven Local AAR publication)./build_python.sh(passed; generated package import smoke test passed)cargo test: 495 passed, 26 ignored; 11 existing live Blocktank staging tests failed because requests toapi.stag.blocktank.tocould not be sent.