fix(toolwalk): observe displaced submission outcomes - #1138
Merged
dennisonbertram merged 3 commits intoAug 3, 2026
Merged
Conversation
dennisonbertram
force-pushed
the
codex/issue-1133-passive-outcome
branch
from
August 3, 2026 19:45
6a3cd1f to
57abd5a
Compare
dennisonbertram
force-pushed
the
codex/issue-1128-submission-handle
branch
from
August 3, 2026 21:38
63cf9fc to
d223738
Compare
dennisonbertram
force-pushed
the
codex/issue-1133-passive-outcome
branch
from
August 3, 2026 21:39
f5186fb to
d2876bb
Compare
dennisonbertram
force-pushed
the
codex/issue-1128-submission-handle
branch
from
August 3, 2026 21:42
d223738 to
eb64af3
Compare
* fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence
dennisonbertram
force-pushed
the
codex/issue-1133-passive-outcome
branch
from
August 3, 2026 21:42
d2876bb to
1f996d8
Compare
dennisonbertram
marked this pull request as ready for review
August 3, 2026 21:47
dennisonbertram
merged commit Aug 3, 2026
626f2bb
into
codex/issue-1128-submission-handle
5 checks passed
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f996d8b53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+571
to
+572
| for task in submissionStreamTasks.values { | ||
| task.cancel() |
There was a problem hiding this comment.
When A remains passively observed after B displacement and a later C starts, this registry contains both local streams, so reset() or load() cancels them here. HarnessClient.streamEvents responds to cancellation by normally finishing its AsyncThrowingStream; consequently the for try await in submit() falls through to recordSubmissionFailure(... "run event stream ended before a terminal event") instead of entering the CancellationError catch. The detached A/C handles are therefore rewritten as transport failures, and an outstanding waiter can report a false failure after an intentional conversation switch; suppress the post-loop EOF failure when the parent task is cancelled.
Useful? React with 👍 / 👎.
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): fence stale interactive affordances * style(macapp): format interactive control views * fix(macapp): fence stale stop and steer actions (#1127) * fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): bind external runs to controls * fix(macapp): fence stale interactive affordances (#1123) * fix(macapp): fence stale interactive affordances * style(macapp): format interactive control views * fix(macapp): fence stale stop and steer actions (#1127) * fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1133
Scope
Passive observation: a selected scheduled B revokes A controls but not A terminal/failure/EOF outcome observation. The merged #1136 child supplies the immutable exact-A cancellation capability; combined acceptance proves terminal judging after B and A-only timeout cancellation after B→C.
Evidence
swift test --package-path macapp --filter PassiveSubmissionOutcomeIntegrationTests(10/10 combined suite)swift format lint --strict --recursive macapp/Sources macapp/Testsswift test --package-path macapp(247 tests / 46 suites)./scripts/test-regression.sh: normal, race, coverage 85.5%, zero uncovered functionsStacked base:
codex/issue-1128-submission-handle/ #1129.