fix(toolwalk): retain immutable timeout authority - #1139
Conversation
6a3cd1f to
57abd5a
Compare
2ec70d7 to
6ab6625
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
dfc843d
into
codex/issue-1133-passive-outcome
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38187bcbac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Task { [client] in | ||
| try? await client.cancel(runID: runID) | ||
| } |
There was a problem hiding this comment.
When the cancellation POST fails because of a transient transport or server error, this task suppresses the error and the method has already returned true. Runner.walk then sleeps briefly and starts the next tool, whose newConversation() detaches A's event stream even though A can still be executing on the server, leaving an unobserved concurrent run that can consume resources or interfere with the walk. Await and propagate the cancellation result before advancing, while retaining the one-shot authority boundary.
Useful? React with 👍 / 👎.
| Swift pass; full repository regression awaits the independent #1135 baseline | ||
| fixture repair, followed by review, hosted checks, and stacked PR promotion. |
There was a problem hiding this comment.
This current-status entry says the repository regression still awaits the #1135 repair, while the newly added issue #1136 plan marks that repair and the complete normal/race/coverage regression as passed. Agents using the active plan cannot tell whether the mandatory gate remains blocked or has completed, so update these records to report one verified state.
AGENTS.md reference: AGENTS.md:L31-L35
Useful? React with 👍 / 👎.
* fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence
* fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence
* fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count
* fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
* fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
* fix(macapp): fence stale interactive affordances * style(macapp): format interactive control views * fix(macapp): fence stale stop and steer actions (#1127) * fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
* fix(macapp): bind external runs to controls * fix(macapp): fence stale interactive affordances (#1123) * fix(macapp): fence stale interactive affordances * style(macapp): format interactive control views * fix(macapp): fence stale stop and steer actions (#1127) * fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
1 participant
Closes #1136
Scope
Immutable owner-token and generation-bound submitted-run cancellation capability; started-only one-shot consumption; terminal/failure/reset/load revocation; reset/load cancels all A/C submission streams. Merged into #1138.
Evidence
swift test --package-path macapp --filter PassiveSubmissionOutcomeIntegrationTests(10/10 final combined suite)swift test --package-path macapp(247 tests / 46 suites)./scripts/test-regression.sh: normal + race + coverage 85.5%, zero uncovered production functionsWas stacked on #1138; merged there as commit
dfc843de.