test(callbacks): stabilize deadline release fixtures - #1143
Merged
Conversation
dennisonbertram
force-pushed
the
codex/issue-1141-callback-fixture
branch
from
August 3, 2026 21:22
495fc09 to
5fed1c7
Compare
dennisonbertram
marked this pull request as ready for review
August 3, 2026 21:26
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1141
What changed
Replaced three 40 ms callback deadline-release fixture assumptions with causal gates: admission entered, heartbeat renewal entered, deadline signaled, and starter context cancellation observed before renewal is released. The attempt-bound case now also proves the original run ID and cleared retry/token/lease state.
Why
The independent deadline can cancel admission before a delayed heartbeat reaches
ExtendLease; the old tests waited for that heartbeat-only side effect and flaked under CI load. No production callback, API, persistence, TUI, or native GUI code changed.Test-first evidence
The hosted #1138 fast check supplied the original expected-red timing failure. The updated fixtures assert the actual cancellation boundary rather than a scheduling side effect.
Verification
go test ./internal/harness/tools -run 'TestCallbackManagerDeadlineRelease(RearmsSingleOwner|PersistsSafeRetryReason|HonorsAttemptBound)$' -count=20 -v(pass, 60.593s)\n-go test -race ./internal/harness/tools -run 'TestCallbackManagerDeadlineRelease(RearmsSingleOwner|PersistsSafeRetryReason|HonorsAttemptBound)$' -count=20 -v(pass, 62.087s)\n-./scripts/test-regression.sh(pass; normal + race + coverage gate, 85.5% total coverage, zero uncovered functions)