fix(macapp): bind ToolWalk to submitted run identity - #1129
Merged
dennisonbertram merged 4 commits intoAug 3, 2026
Merged
Conversation
This was referenced Aug 3, 2026
Open
fix(toolwalk): observe displaced submission terminal outcome without acting on replacement run
#1133
Open
dennisonbertram
force-pushed
the
codex/issue-1125-action-owner
branch
from
August 3, 2026 21:37
d2cd29c to
2968674
Compare
dennisonbertram
force-pushed
the
codex/issue-1128-submission-handle
branch
from
August 3, 2026 21:38
63cf9fc to
d223738
Compare
dennisonbertram
force-pushed
the
codex/issue-1125-action-owner
branch
from
August 3, 2026 21:42
2968674 to
b2ae9ba
Compare
dennisonbertram
force-pushed
the
codex/issue-1128-submission-handle
branch
from
August 3, 2026 21:42
d223738 to
eb64af3
Compare
* fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count
This was referenced Aug 3, 2026
fix(toolwalk): retain immutable timeout cancellation authority across subsequent run selection
#1136
Open
dennisonbertram
marked this pull request as ready for review
August 3, 2026 23:09
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
dennisonbertram
merged commit Aug 3, 2026
a52c50a
into
codex/issue-1125-action-owner
5 checks passed
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a0bedffa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+540
to
+541
| if let activeSubmission, activeSubmission.runID != runID { | ||
| activeSubmission.markDisplaced() |
There was a problem hiding this comment.
When submitting another turn in an existing conversation, harnessd can publish A's conversation-stream lifecycle event before the startRun HTTP response assigns activeSubmission.runID. Because nil != runID, this marks A as permanently displaced even though the event belongs to A itself; the later acknowledgement does not reverse that state, so A remains classified as external, the UI can show “Scheduled run active,” and the returned submission handle incorrectly disables its normal ownership behavior. Defer this decision while the submission is unresolved, then compare the response ID with the selected run.
Useful? React with 👍 / 👎.
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): fence stale interactive affordances * style(macapp): format interactive control views * fix(macapp): fence stale stop and steer actions (#1127) * fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram
added a commit
that referenced
this pull request
Aug 3, 2026
* fix(macapp): bind external runs to controls * fix(macapp): fence stale interactive affordances (#1123) * fix(macapp): fence stale interactive affordances * style(macapp): format interactive control views * fix(macapp): fence stale stop and steer actions (#1127) * fix(macapp): fence stale stop and steer actions * fix(macapp): bind ToolWalk to submitted run identity (#1129) * fix(macapp): bind ToolWalk to submitted run identity * fix(macapp): retain submitted run outcomes (#1131) * fix(toolwalk): observe displaced submission outcomes (#1138) * fix(toolwalk): observe displaced submission outcomes * fix(toolwalk): retain immutable timeout authority (#1139) * fix(toolwalk): retain immutable timeout authority * test(toolwalk): prove displaced timeout orchestration * docs(plan): record timeout authority regression evidence * docs: correct focused orchestration evidence count * fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunSubmissionfrom native submit paths and bind ToolWalk wait, auto-controls, timeout, and verdict to itCloses #1128
Stack
d2cd29cf(codex/issue-1125-action-owner)Deterministic TDD evidence
.displaced, including after an A terminal, with zero B cancel/approve/deny/input/steer requestsVerification
swift format lint --strict --recursive Sources Testsswift test --filter 'RunSubmissionTests|RunSessionExternalControlTests|ToolWalkTests'(37 tests / 5 suites)swift test(230 tests / 44 suites)./scripts/test-regression.sh: normal/race passed; coverage 85.5%, zero uncovered functions