Skip to content

fix(toolwalk): gate timeout cancellation by deadline ticket - #1146

Merged
dennisonbertram merged 1 commit into
codex/issue-1128-submission-handlefrom
codex/issue-1136-timeout-ticket
Aug 3, 2026
Merged

fix(toolwalk): gate timeout cancellation by deadline ticket#1146
dennisonbertram merged 1 commit into
codex/issue-1128-submission-handlefrom
codex/issue-1136-timeout-ticket

Conversation

@dennisonbertram

@dennisonbertram dennisonbertram commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Closes #1136

Summary

  • binds ToolWalk's timeout duration once when it creates an immutable RunSubmission; the public GUI submit() remains parameter-free
  • derives the sole absolute deadline only when that submission is accepted as started
  • exposes only a cached, no-duration timeout gate; raw timeout transport and post-submit rearm APIs are absent
  • keeps ticket consumption A-scoped, started-only, one-shot, generation-fenced, and transport-only
  • proves no ticket before the original deadline; B -> C -> A exact-one dispatch; terminal/failure/reset/load revocation; duplicate refusal; zero B/C actions

Test-first evidence

  • Red: former direct timeout-cancellation call sites and post-submit duration configuration are removed by the new API boundary.
  • Green: swift test --package-path macapp --filter PassiveSubmissionOutcomeIntegrationTests (14/14).

Verification

  • cd macapp && swift format lint --strict --recursive Sources Tests
  • swift test --package-path macapp (252 tests / 46 suites)
  • ./scripts/test-regression.sh (normal, race, coverage; 85.5%, zero uncovered production functions)

Stack

Targets codex/issue-1128-submission-handle (#1129); do not merge directly to main.

@dennisonbertram
dennisonbertram force-pushed the codex/issue-1136-timeout-ticket branch from 05ee403 to 431bd22 Compare August 3, 2026 23:01
@dennisonbertram
dennisonbertram marked this pull request as ready for review August 3, 2026 23:05
@dennisonbertram
dennisonbertram merged commit 0a0bedf into codex/issue-1128-submission-handle Aug 3, 2026
5 checks passed
@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@dennisonbertram
dennisonbertram deleted the codex/issue-1136-timeout-ticket branch August 3, 2026 23:05
dennisonbertram added a commit that referenced this pull request Aug 3, 2026
* fix(macapp): bind ToolWalk to submitted run identity

* fix(macapp): retain submitted run outcomes (#1131)

* fix(toolwalk): observe displaced submission outcomes (#1138)

* fix(toolwalk): observe displaced submission outcomes

* fix(toolwalk): retain immutable timeout authority (#1139)

* fix(toolwalk): retain immutable timeout authority

* test(toolwalk): prove displaced timeout orchestration

* docs(plan): record timeout authority regression evidence

* docs: correct focused orchestration evidence count

* fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram added a commit that referenced this pull request Aug 3, 2026
* fix(macapp): fence stale stop and steer actions

* fix(macapp): bind ToolWalk to submitted run identity (#1129)

* fix(macapp): bind ToolWalk to submitted run identity

* fix(macapp): retain submitted run outcomes (#1131)

* fix(toolwalk): observe displaced submission outcomes (#1138)

* fix(toolwalk): observe displaced submission outcomes

* fix(toolwalk): retain immutable timeout authority (#1139)

* fix(toolwalk): retain immutable timeout authority

* test(toolwalk): prove displaced timeout orchestration

* docs(plan): record timeout authority regression evidence

* docs: correct focused orchestration evidence count

* fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram added a commit that referenced this pull request Aug 3, 2026
* fix(macapp): fence stale interactive affordances

* style(macapp): format interactive control views

* fix(macapp): fence stale stop and steer actions (#1127)

* fix(macapp): fence stale stop and steer actions

* fix(macapp): bind ToolWalk to submitted run identity (#1129)

* fix(macapp): bind ToolWalk to submitted run identity

* fix(macapp): retain submitted run outcomes (#1131)

* fix(toolwalk): observe displaced submission outcomes (#1138)

* fix(toolwalk): observe displaced submission outcomes

* fix(toolwalk): retain immutable timeout authority (#1139)

* fix(toolwalk): retain immutable timeout authority

* test(toolwalk): prove displaced timeout orchestration

* docs(plan): record timeout authority regression evidence

* docs: correct focused orchestration evidence count

* fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
dennisonbertram added a commit that referenced this pull request Aug 3, 2026
* fix(macapp): bind external runs to controls

* fix(macapp): fence stale interactive affordances (#1123)

* fix(macapp): fence stale interactive affordances

* style(macapp): format interactive control views

* fix(macapp): fence stale stop and steer actions (#1127)

* fix(macapp): fence stale stop and steer actions

* fix(macapp): bind ToolWalk to submitted run identity (#1129)

* fix(macapp): bind ToolWalk to submitted run identity

* fix(macapp): retain submitted run outcomes (#1131)

* fix(toolwalk): observe displaced submission outcomes (#1138)

* fix(toolwalk): observe displaced submission outcomes

* fix(toolwalk): retain immutable timeout authority (#1139)

* fix(toolwalk): retain immutable timeout authority

* test(toolwalk): prove displaced timeout orchestration

* docs(plan): record timeout authority regression evidence

* docs: correct focused orchestration evidence count

* fix(toolwalk): gate timeout cancellation by deadline ticket (#1146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant