Skip to content

Fix AskUserQuestion status regression test race - #1045

Merged
dennisonbertram merged 1 commit into
mainfrom
codex/issue-1044-ask-status-race
Jul 31, 2026
Merged

Fix AskUserQuestion status regression test race#1045
dennisonbertram merged 1 commit into
mainfrom
codex/issue-1044-ask-status-race

Conversation

@dennisonbertram

Copy link
Copy Markdown
Owner

Closes #1044

Related: #1000, #1043, #1041, #1033

What changed

  • publish the returned run ID to the provider fixture through a capacity-one channel
  • preserve the step-two mid-run status observation after a denied AskUserQuestion call
  • document the exact GitHub race evidence and cross-surface impact

Verification

  • focused normal and race at -count=100
  • complete internal/harness normal and race
  • ./scripts/test-regression.sh (normal, race, coverage 85.6%, zero uncovered functions)

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@dennisonbertram

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 40d5eef226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dennisonbertram
dennisonbertram force-pushed the codex/issue-1044-ask-status-race branch from 40d5eef to b3afc7e Compare July 31, 2026 00:06

Copy link
Copy Markdown
Owner Author

@codex review

Exact head: b3afc7ec487c60762a91a1219ceb92c523ef0e78

Rebased onto current origin/main (fedcf6073135deb7cce1fa49921aa698a9cc7cd7) with the six-file scope preserved. Focused normal/race stress at -count=100, complete internal/harness normal/race, and foreground non-TTY ./scripts/test-regression.sh all pass; coverage gate: 85.6%, zero uncovered functions.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: b3afc7ec48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dennisonbertram
dennisonbertram merged commit b3afc7e into main Jul 31, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: AskUserQuestion status regression test races run ID publication

1 participant