Stabilize swarm activation control lifecycle - #1047
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Jul 30, 2026
dennisonbertram
force-pushed
the
codex/issue-1046-swarm-activation-control
branch
from
July 31, 2026 21:01
a70eede to
a84d1ef
Compare
dennisonbertram
force-pushed
the
codex/issue-1046-swarm-activation-control
branch
from
July 31, 2026 21:54
a84d1ef to
34c0d86
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1046
Related: #1000, #1045, #1043, #1041, #1033, #1076
What changed
Why
The member run consumed both scripted provider turns. The unrestricted control could then terminate before the test inspected its activated tool definitions, and terminal cleanup removed the activation. That made
TestAgentSwarmDeniedForMemberRunsintermittently reportagent_swarmmissing even though production authorization was correct.This exact race blocked the production merge gate for #1076/#1079. PR #1047 keeps the control run live at the point whose behavior the test intends to assert.
Verification on rebased head
Exact head:
34c0d8627558b13851ef81ec0d25c930c045b883Rebased onto:
3384616a8598a7fb73638220601a4a7d24c9ecedgo test ./internal/harness -run '^TestAgentSwarmDeniedForMemberRuns$' -count=100— PASSgo test -race ./internal/harness -run '^TestAgentSwarmDeniedForMemberRuns$' -count=100— PASS./scripts/test-regression.sh— PASS85.6%,zero-functions=0)git diff --check origin/main...HEAD— PASSThe earlier hosted race failure on the stale PR head was an unrelated retention race that is already fixed on current
main. The known provider-key capture synchronization defect was then repaired and merged separately by #1053. Hosted checks will rerun on this exact rebased head.Rollout and rollback
This changes test synchronization only. Rollback is a normal revert of this PR; no production data or schema migration is involved.