Stabilize workflow failure event wait - #1050
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fedcf60731
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| events := append([]Event(nil), history...) | ||
| deadline := time.After(2 * time.Second) | ||
| deadline := time.NewTimer(10 * time.Second) |
There was a problem hiding this comment.
When execute emits workflow.failed after Subscribe takes its GetEvents snapshot but before it registers live under e.mu (engine.go:137-147), the event is absent from both returned history and the channel forever. Since this test starts execution before subscribing, that race can still produce the reported failed stored state with no terminal event; changing the deadline to ten seconds only makes the same failure eight seconds slower. Make history retrieval and subscriber registration atomic relative to emit, or otherwise close that gap, rather than relying on a longer timer.
AGENTS.md reference: AGENTS.md:L31-L35
Useful? React with 👍 / 👎.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Closes #1049
Related: #958, #1000, #1048, #1047, #1045, #1043, #1041, #1033
What changed
Verification