[No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces - #99799
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#99758 Intuit Enterprise Suite now available to all workspaces#99799MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…ction Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://6c1db4ae.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site updates for #99758, which removed the
intuitEnterpriseSuitebeta and the policy-type condition. Intuit Enterprise Suite is now listed as its own connection on every workspace's Accounting page, directly below QuickBooks Online, and connecting it requires the Control plan.The help site did not describe that.
Connect-to-QuickBooks-Online.mdonly said the QuickBooks Online connection "also works with Intuit Enterprise Suite", which reads as one connection covering both. There was no article for the Intuit Enterprise Suite connection flow.What changed
docs/articles/new-expensify/connections/quickbooks-online/Connect-to-Intuit-Enterprise-Suite.md. Covers who can connect it, the steps to connect, what happens after connecting, and an FAQ. Written todocs/TEMPLATE.md: one#title plus# FAQ, task-based##headings only, no###, and a<!-- SCREENSHOT: -->placeholder.Connect-to-QuickBooks-Online.md:UI verification
Every label was checked against the live app rather than the source, per
docs/HELPSITE_NAMING_CONVENTIONS.md:Intuit Enterprise SuiteConnect(same as QuickBooks Online's)QuickBooks Online, thenIntuit Enterprise SuiteIntegrate/AccountingUpgrade, badgeUnlock this feature, body "Our Intuit Enterprise Suite integration is only available on the Control plan…", buttonUpgradeLeft out on purpose: the "Intuit Enterprise Suite" column in the QuickBooks Online feature table. It documents feature support by Intuit subscription level, so it is still useful there — but flagging it in case you would rather move it to the new article.
Evidence (2)
Accounting page listing QuickBooks Online and Intuit Enterprise Suite, both with Connect buttons
Upgrade modal shown after clicking Connect on Intuit Enterprise Suite for a Collect plan workspace
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/658857
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.