Xilinx asu ecc standalone by night1rider · Pull Request #11053 · wolfSSL/wolfssl

night1rider · 2026-08-04T20:45:24Z

No description provided.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

github-actions · 2026-08-04T21:26:48Z

MemBrowse Memory Report

linuxkm-pie

Data: __patchable_function_entries +48 B (+0.2%, 26,632 B)

linuxkm-standard

Data: __patchable_function_entries +48 B (+0.1%, 49,496 B)
No memory changes detected for:
gcc-arm-cortex-m0plus
gcc-arm-cortex-m3
gcc-arm-cortex-m4
gcc-arm-cortex-m4-baremetal
gcc-arm-cortex-m4-crypto-only
gcc-arm-cortex-m4-dtls13
gcc-arm-cortex-m4-min-ecc
gcc-arm-cortex-m4-openssl-compat
gcc-arm-cortex-m4-pkcs7
gcc-arm-cortex-m4-pq
gcc-arm-cortex-m4-rsa-only
gcc-arm-cortex-m4-sp-math
gcc-arm-cortex-m4-tls12
gcc-arm-cortex-m4-tls13
gcc-arm-cortex-m7
gcc-arm-cortex-m7-pq
gcc-arm-cortex-m7-tls13
stm32-sim-stm32h753

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 21
21 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 14
14 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfssl-bugs
Failed targets: wolfcrypt-src, wolfssl-src

Findings: 10
10 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfssl-bugs
Failed targets: wolfcrypt-src, wolfssl-src

Findings: 6
6 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfssl-bugs
Failed targets: wolfcrypt-src, wolfssl-src

Findings: 6
6 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfssl-bugs
Failed targets: wolfcrypt-src, wolfssl-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfssl-bugs
Failed targets: wolfcrypt-src, wolfssl-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 6
6 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 8
8 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Blocking findings require changes before merge.

…e named roles

…annot encode

wolfSSL-Fenrir-bot

Fenrir Automated Review — PR #11053

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

… sign, ECDH and ECIES decrypt

…xists

philljj · 2026-08-20T03:09:18Z


 #ifdef HAVE_ED448
-void bench_ed448KeyGen(void)
+void bench_ed448KeyGen(int useDeviceID)


I don't think the wc_ed448_make_key implementation supports crypto callbacks (it's only sign / verify). So the useDeviceID is unused.

philljj · 2026-08-20T03:09:45Z

+    /* Extra row using a 16-byte IV alongside the 12-byte default above. The
+     * stats list keeps the label by pointer, so it must outlive this call. */
+    {
+        static char gmacIvStr[40];


I'm not sure this is memory or thread safe.

gmacIvStr gets passed down

bench_gmac_internal

bench_stats_sym_finish

bench_stats_add()

In bench_stats_add() it becomes const char * desc, which does

bstat->desc == desc

so it shallow copies the gmacIvStr pointer.

philljj · 2026-08-20T03:11:20Z

+    ret = wc_InitRng_ex(&myrng, HEAP_HINT,
+        useDeviceID ? devId : INVALID_DEVID);
 #else
    ret = wc_InitRng(&myrng);


The useDeviceID is unused when HAVE_FIPS

night1rider self-assigned this Aug 4, 2026

night1rider requested a review from wolfSSL-Fenrir-bot August 4, 2026 20:45

wolfSSL-Fenrir-bot reviewed Aug 4, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

night1rider commented Aug 5, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

night1rider commented Aug 5, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

night1rider force-pushed the Xilinx-ASU-ECC-standalone branch 2 times, most recently from db9d0e3 to 0478f96 Compare August 11, 2026 21:17

night1rider requested a review from wolfSSL-Fenrir-bot August 11, 2026 21:18

wolfSSL-Fenrir-bot reviewed Aug 11, 2026

View reviewed changes

night1rider requested a review from wolfSSL-Fenrir-bot August 12, 2026 06:12

wolfSSL-Fenrir-bot reviewed Aug 12, 2026

View reviewed changes

night1rider force-pushed the Xilinx-ASU-ECC-standalone branch from 28d23a6 to 61596e5 Compare August 12, 2026 15:47

night1rider requested a review from wolfSSL-Fenrir-bot August 12, 2026 15:48

wolfSSL-Fenrir-bot reviewed Aug 12, 2026

View reviewed changes

night1rider requested a review from wolfSSL-Fenrir-bot August 12, 2026 17:30

wolfSSL-Fenrir-bot reviewed Aug 12, 2026

View reviewed changes

night1rider requested a review from wolfSSL-Fenrir-bot August 12, 2026 19:02

wolfSSL-Fenrir-bot reviewed Aug 12, 2026

View reviewed changes

night1rider requested a review from wolfSSL-Fenrir-bot August 12, 2026 20:12

wolfSSL-Fenrir-bot reviewed Aug 12, 2026

View reviewed changes

night1rider force-pushed the Xilinx-ASU-ECC-standalone branch 2 times, most recently from 0db5b02 to 300bbb4 Compare August 13, 2026 05:17

night1rider requested a review from wolfSSL-Fenrir-bot August 13, 2026 05:26

wolfSSL-Fenrir-bot reviewed Aug 13, 2026

View reviewed changes

night1rider requested a review from wolfSSL-Fenrir-bot August 13, 2026 06:09

wolfSSL-Fenrir-bot reviewed Aug 13, 2026

View reviewed changes

night1rider force-pushed the Xilinx-ASU-ECC-standalone branch from 5eacdde to 693e3f5 Compare August 13, 2026 18:33

night1rider requested a review from wolfSSL-Fenrir-bot August 13, 2026 18:34

wolfSSL-Fenrir-bot reviewed Aug 13, 2026

View reviewed changes

benchmark: add AES key wrap and padded key wrap benchmarks

f71ee94

philljj requested a review from wolfSSL-Fenrir-bot August 19, 2026 13:45

wolfSSL-Fenrir-bot requested changes Aug 19, 2026

View reviewed changes

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecies.c

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

philljj assigned night1rider and unassigned wolfSSL-Bot Aug 19, 2026

Xilinx Versal Gen2 ASU ECIES: accept the default context, not just th…

4426bf9

…e named roles

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecies.c

night1rider added 3 commits August 19, 2026 09:38

benchmark: keep the AES-CCM nonce sweep labels alive for the stats list

c42b8e9

benchmark: keep the GMAC iv16 label alive for the stats list

54cc8f0

benchmark: skip AES-CCM nonce and block size pairs the length field c…

e5a6af1

…annot encode

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/benchmark/benchmark.c

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecies.c Outdated

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/benchmark/benchmark.c Outdated

night1rider commented Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/benchmark/benchmark.c

night1rider requested a review from wolfSSL-Fenrir-bot August 19, 2026 16:49

wolfSSL-Fenrir-bot reviewed Aug 19, 2026

View reviewed changes

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecc.c

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecies.c

Comment thread wolfcrypt/src/port/xilinx/versal_gen2_asu/asu_ecdh.c

night1rider added 2 commits August 19, 2026 12:39

Xilinx Versal Gen2 ASU: add a port README

0b16211

Xilinx Versal Gen2 ASU: require a private key before offloading ECDSA…

5d9b2e0

… sign, ECDH and ECIES decrypt

night1rider force-pushed the Xilinx-ASU-ECC-standalone branch from ff931d8 to 5d9b2e0 Compare August 19, 2026 18:40

benchmark: build the AES key wrap benchmarks only where the _ex API e…

c72ae34

…xists

night1rider assigned wolfSSL-Bot and unassigned night1rider Aug 19, 2026

philljj requested review from JacobBarthelmeh and philljj August 19, 2026 23:05

philljj requested changes Aug 20, 2026

View reviewed changes

philljj assigned night1rider and unassigned wolfSSL-Bot Aug 20, 2026

Uh oh!

Conversation

night1rider commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

MemBrowse Memory Report

linuxkm-pie

linuxkm-standard

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

Fenrir Automated Review — PR #11053

Uh oh!

Uh oh!

night1rider commented Aug 4, 2026 •

edited

Loading

github-actions Bot commented Aug 4, 2026 •

edited

Loading

philljj Aug 20, 2026 •

edited

Loading

philljj Aug 20, 2026 •

edited

Loading