fix: replace url-parse with native URL API#4033
Merged
Merged
Conversation
Remove the url-parse dependency and use the built-in URL and URLSearchParams APIs in AvatarHelper instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
url-parsedependency fromreact-native-ui-liband uses the nativeURL/URLSearchParamsAPIs inAvatarHelperinstead.isGravatarUrlandpatchGravatarUrlnow use the globalURLconstructor (no import shadowing)patchGravatarUrlsetsd=404and removesdefaultviasearchParamsurl-parseand@types/url-parsefrom package manifests and lockfileThis fully resolves the OSV supply-chain issue without needing to bump
url-parse(see #4031).Changelog
AvatarHelper — Removed
url-parsedependency; Gravatar URL helpers now use nativeURLAPIs.Additional info
All existing
AvatarHelpertests pass (yarn workspace react-native-ui-lib test AvatarHelper.spec.js).