fix: guard isGravatarUrl against invalid URL strings#4034
Open
adids1221 wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #4033 replaced
url-parsewith the nativeURLAPI inAvatarHelper. However, the nativeURLconstructor throws aTypeErrorwhen given an invalid URL string (e.g.'fakeUrl',''), unlikeurl-parsewhich was lenient.This caused headless test failures in
wix-react-native-ui-libwhen Avatar components received non-URL strings as the image source —isGravatarUrlwould throw instead of returningfalse.The fix wraps
new URL(url)in atry/catchinsideisGravatarUrland returnsfalsefor any input that isn't a valid URL.Changelog
AvatarHelper —
isGravatarUrlnow returnsfalsefor invalid URL strings instead of throwing.Additional info
Fixes the regression introduced by #4033. Caught by headless tests in
wix-react-native-ui-libwhere Avatar receives arbitrary strings as image URIs.