feat: support deleting configured model providers (#301)

.changeset/model-provider-deletion.md

@@ -0,0 +1,7 @@
+---
+'@truefoundry/trueforge': minor
+'@truefoundry/trueforge-sdk': patch
+'@truefoundry/trueforge-ui': patch
+---
+
+Add model-provider deletion via the settings API, SDK, and UI adapter.

.github/fern/openapi/openapi.json

@@ -1036,6 +1036,10 @@
         "properties": {},
         "type": "object"
       },
+      "DeleteModelProviderResponse": {
+        "properties": {},
+        "type": "object"
+      },
       "DynamicSubAgentsConfig": {
         "default": {
           "enabled": true
@@ -6663,6 +6667,55 @@
         "x-fern-sdk-method-name": "create_or_update"
       }
     },
+    "/api/v1/settings/model-providers/{name}": {
+      "delete": {
+        "description": "Deletes a configured model provider by name.",
+        "parameters": [
+          {
+            "description": "Model provider name.",
+            "in": "path",
+            "name": "name",
+            "required": true,
+            "schema": {
+              "description": "Model provider name.",
+              "minLength": 1,
+              "type": "string"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/DeleteModelProviderResponse"
+                }
+              }
+            },
+            "description": "The model provider was deleted."
+          },
+          "404": {
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/RequestErrorResponse"
+                }
+              }
+            },
+            "description": "Model provider not found."
+          }
+        },
+        "summary": "Delete a model provider",
+        "tags": [
+          "Models"
+        ],
+        "x-fern-sdk-group-name": [
+          "settings",
+          "modelProviders"
+        ],
+        "x-fern-sdk-method-name": "delete"
+      }
+    },
     "/api/v1/settings/sandbox-providers": {
       "get": {
         "description": "The single configured sandbox provider for this tenant. `auth.api_key` is redacted.",

docs/openapi.json

@@ -1036,6 +1036,10 @@
         "properties": {},
         "type": "object"
       },
+      "DeleteModelProviderResponse": {
+        "properties": {},
+        "type": "object"
+      },
       "DynamicSubAgentsConfig": {
         "default": {
           "enabled": true
@@ -6663,6 +6667,55 @@
         "x-fern-sdk-method-name": "create_or_update"
       }
     },
+    "/api/v1/settings/model-providers/{name}": {
+      "delete": {
+        "description": "Deletes a configured model provider by name.",
+        "parameters": [
+          {
+            "description": "Model provider name.",
+            "in": "path",
+            "name": "name",
+            "required": true,
+            "schema": {
+              "description": "Model provider name.",
+              "minLength": 1,
+              "type": "string"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/DeleteModelProviderResponse"
+                }
+              }
+            },
+            "description": "The model provider was deleted."
+          },
+          "404": {
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/RequestErrorResponse"
+                }
+              }
+            },
+            "description": "Model provider not found."
+          }
+        },
+        "summary": "Delete a model provider",
+        "tags": [
+          "Models"
+        ],
+        "x-fern-sdk-group-name": [
+          "settings",
+          "modelProviders"
+        ],
+        "x-fern-sdk-method-name": "delete"
+      }
+    },
     "/api/v1/settings/sandbox-providers": {
       "get": {
         "description": "The single configured sandbox provider for this tenant. `auth.api_key` is redacted.",

packages/trueforge-sdk/reference.md

@@ -2497,6 +2497,69 @@ await client.settings.modelProviders.createOrUpdate({
 </dl>
 
 
+</dd>
+</dl>
+</details>
+
+<details><summary><code>client.settings.modelProviders.<a href="/src/api/resources/settings/resources/modelProviders/client/Client.ts">delete</a>(name) -> void</code></summary>
+<dl>
+<dd>
+
+#### 📝 Description
+
+<dl>
+<dd>
+
+<dl>
+<dd>
+
+Deletes a configured model provider by name.
+</dd>
+</dl>
+</dd>
+</dl>
+
+#### 🔌 Usage
+
+<dl>
+<dd>
+
+<dl>
+<dd>
+
+```typescript
+await client.settings.modelProviders.delete("name");
+
+```
+</dd>
+</dl>
+</dd>
+</dl>
+
+#### ⚙️ Parameters
+
+<dl>
+<dd>
+
+<dl>
+<dd>
+
+**name:** `string` — Model provider name.
+
+</dd>
+</dl>
+
+<dl>
+<dd>
+
+**requestOptions:** `ModelProvidersClient.RequestOptions` 
+
+</dd>
+</dl>
+</dd>
+</dl>
+
+
 </dd>
 </dl>
 </details>

packages/trueforge-sdk/src/api/resources/settings/resources/modelProviders/client/Client.ts

@@ -353,4 +353,80 @@ export class ModelProvidersClient {
             "/api/v1/settings/model-providers",
         );
     }
+
+    /**
+     * Deletes a configured model provider by name.
+     *
+     * @param {string} name - Model provider name.
+     * @param {ModelProvidersClient.RequestOptions} requestOptions - Request-specific configuration.
+     *
+     * @throws {@link TrueForge.NotFoundError}
+     * @throws {@link errors.TrueForgeError}
+     * @throws {@link errors.TrueForgeTimeoutError}
+     *
+     * @example
+     *     await client.settings.modelProviders.delete("name")
+     */
+    public delete(name: string, requestOptions?: ModelProvidersClient.RequestOptions): core.HttpResponsePromise<void> {
+        return core.HttpResponsePromise.fromPromise(this.__delete(name, requestOptions));
+    }
+
+    private async __delete(
+        name: string,
+        requestOptions?: ModelProvidersClient.RequestOptions,
+    ): Promise<core.WithRawResponse<void>> {
+        const _authRequest: core.AuthRequest = await this._options.authProvider.getAuthRequest();
+        const _headers: core.Fetcher.Args["headers"] = mergeHeaders(
+            _authRequest.headers,
+            this._options?.headers,
+            requestOptions?.headers,
+        );
+        const _response = await (this._options.fetcher ?? core.fetcher)({
+            url: core.url.join(
+                (await core.Supplier.get(this._options.baseUrl)) ??
+                    (await core.Supplier.get(this._options.environment)),
+                `api/v1/settings/model-providers/${core.url.encodePathParam(name)}`,
+            ),
+            method: "DELETE",
+            headers: _headers,
+            queryString: core.url.queryBuilder().mergeAdditional(requestOptions?.queryParams).build(),
+            timeoutMs: (requestOptions?.timeoutInSeconds ?? this._options?.timeoutInSeconds ?? 60) * 1000,
+            maxRetries: requestOptions?.maxRetries ?? this._options?.maxRetries,
+            abortSignal: requestOptions?.abortSignal,
+            fetchFn: this._options?.fetch,
+            logging: this._options.logging,
+        });
+        if (_response.ok) {
+            return { data: undefined, rawResponse: _response.rawResponse };
+        }
+
+        if (_response.error.reason === "status-code") {
+            switch (_response.error.statusCode) {
+                case 404:
+                    throw new TrueForge.NotFoundError(
+                        serializers.RequestErrorResponse.parseOrThrow(_response.error.body, {
+                            unrecognizedObjectKeys: "passthrough",
+                            allowUnrecognizedUnionMembers: true,
+                            allowUnrecognizedEnumValues: true,
+                            skipValidation: true,
+                            breadcrumbsPrefix: ["response"],
+                        }),
+                        _response.rawResponse,
+                    );
+                default:
+                    throw new errors.TrueForgeError({
+                        statusCode: _response.error.statusCode,
+                        body: _response.error.body,
+                        rawResponse: _response.rawResponse,
+                    });
+            }
+        }
+
+        return handleNonStatusCodeError(
+            _response.error,
+            _response.rawResponse,
+            "DELETE",
+            "/api/v1/settings/model-providers/{name}",
+        );
+    }
 }

packages/trueforge-sdk/tests/tsconfig.json

@@ -3,7 +3,7 @@
     "compilerOptions": {
         "outDir": null,
         "rootDir": "..",
-        "types": ["vitest/globals"]
+        "types": ["node", "vitest/globals"]
     },
     "include": ["../src", "../tests"],
     "exclude": []

packages/trueforge-sdk/tests/wire/settings/modelProviders.test.ts

@@ -368,4 +368,33 @@ describe("ModelProvidersClient", () => {
             });
         }).rejects.toThrow(TrueForgeTypes.BadRequestError);
     });
+
+    test("delete (1)", async () => {
+        const server = mockServerPool.createServer();
+        const client = new TrueForge({ maxRetries: 0, token: "test", baseUrl: server.baseUrl });
+
+        server.mockEndpoint().delete("/api/v1/settings/model-providers/name").respondWith().statusCode(200).build();
+
+        const response = await client.settings.modelProviders.delete("name");
+        expect(response).toEqual(undefined);
+    });
+
+    test("delete (2)", async () => {
+        const server = mockServerPool.createServer();
+        const client = new TrueForge({ maxRetries: 0, token: "test", baseUrl: server.baseUrl });
+
+        const rawResponseBody = { error: { message: "message" } };
+
+        server
+            .mockEndpoint()
+            .delete("/api/v1/settings/model-providers/name")
+            .respondWith()
+            .statusCode(404)
+            .jsonBody(rawResponseBody)
+            .build();
+
+        await expect(async () => {
+            return await client.settings.modelProviders.delete("name");
+        }).rejects.toThrow(TrueForgeTypes.NotFoundError);
+    });
 });

packages/trueforge-ui/src/containers/SettingsBuilder/ModelSettings.tsx

@@ -391,7 +391,7 @@ const ModelSettings = () => {
                                 onClick={() => {
                                   handleUpdateModels(
                                     provider,
-                                    provider.models.filter(item => item.id !== model.id),
+                                    provider.models.filter(m => m.id !== model.id),
                                   );
                                 }}
                               >

packages/trueforge-ui/src/plugins/trueforge-agent-server-adapter/catalogs/modelProviderCatalog.ts

@@ -175,5 +175,8 @@ export function createModelProviderCatalog(
       });
       return toUiModelProvider(body.data);
     },
+    deleteModelProvider: async ({ id }) => {
+      await client.settings.modelProviders.delete(id);
+    },
   };
 }