feat: support deleting configured model providers (#301) - #369
feat: support deleting configured model providers (#301)#369azaanaliraza wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: eea4592 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 98e9c89. Configure here.
|
We can start a code review once the extra changes are cleaned up and branch is rebased to resolve conflicts |


Summary
Add support for deleting configured model providers through the
model-provider settings API and UI adapter.
Closes #301 - [Cannot delete configured model providers from Model Settings]
Changes
deleteProvidertoIModelProviderStore.client.settings.modelProviders.delete(...)is available.How was this tested?
pnpm buildpassed.pnpm testpassed.pnpm typecheckpassed.pnpm lint:cipassed.pnpm format:checkpassed.packages/trueforge-sdktests passed:Checklist
pnpm buildpassespnpm testpassespnpm typecheckpassespnpm lint:cipassespnpm format:checkpasses.env.exampledo not require updatesNote
Medium Risk
Deletes tenant configuration that agents may depend on for model routing; behavior is scoped and tested but operational impact if providers are removed while still in use.
Overview
Adds end-to-end support for removing a configured model provider by name, closing the gap where settings could create/update providers but not delete them.
The settings API exposes
DELETE /api/v1/settings/model-providers/{name}, returning an empty 200 or 404 when the provider is missing. Persistence goes through a newdeleteProvideron the model-provider store (Postgres and SQLite), tenant-scoped with a boolean indicating whether a row was removed.The TypeScript SDK gains
client.settings.modelProviders.delete(name)(includingNotFoundErroron 404), OpenAPI/docs are updated, and the TrueForge UI catalog adapter implementsdeleteModelProviderso existing Model Settings delete flows call the new API.Tests cover store contracts, API handlers, SDK wire mocks, and a UI case confirming per-model trash still updates the provider manifest without invoking provider deletion.
Reviewed by Cursor Bugbot for commit eea4592. Bugbot is set up for automated code reviews on this repo. Configure here.