Skip to content

chore: fix TypeScript declarations lint errors #12298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
May 27, 2026
+0 −1
Merged

chore: fix TypeScript declarations lint errors #12298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e05cb20
chore: handle empty TypeScript declaration lint selections
puneetdixit200 May 26, 2026
2cfd967
Apply suggestions from code review
kgryte May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/lint_random_files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,6 @@ jobs:
id: lint-typescript-declarations
if: ( github.event.inputs.javascript != 'false' ) && ( success() || failure() )
run: |
set -o pipefail
files=$(echo "${{ steps.random-files.outputs.files }}" | tr ',' '\n' | grep -E '\.d\.ts$' | tr '\n' ' ')
if [[ -n "${files}" ]]; then
make TYPESCRIPT_DECLARATIONS_LINTER=eslint lint-typescript-declarations-files FAST_FAIL=0 FILES="${files}" 2>&1 | tee lint_typescript_declarations_errors.txt
Expand Down