Skip to content

chore: fix TypeScript declarations lint errors#12298

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
puneetdixit200:chore/fix-empty-ts-declarations-lint
May 27, 2026
Merged

chore: fix TypeScript declarations lint errors#12298
kgryte merged 2 commits into
stdlib-js:developfrom
puneetdixit200:chore/fix-empty-ts-declarations-lint

Conversation

@puneetdixit200
Copy link
Copy Markdown
Contributor

Resolves #11896.

Description

This pull request:

  • handles random lint runs where no TypeScript declaration files are selected, preventing grep under set -o pipefail from failing before the existing guard can skip linting.

Related Issues

This pull request has the following related issues:

Questions

No.

Other

Verification:

  • Reproduced the existing no-match file selection failure with exit code 1.
  • Verified the patched no-match case exits with code 0 and prints No TypeScript declaration files to lint.
  • Verified a matching .d.ts file is still selected for linting.
  • Ran git diff --check.

Checklist

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

I used AI assistance to inspect the workflow failure, reason about the shell behavior, and prepare the small workflow change. I reviewed the diff and verification before submission.


@stdlib-js/reviewers

Signed-off-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>
@puneetdixit200 puneetdixit200 requested a review from a team May 26, 2026 05:17
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels May 26, 2026
Comment thread .github/workflows/lint_random_files.yml Outdated
Comment thread .github/workflows/lint_random_files.yml Outdated
Comment thread .github/workflows/lint_random_files.yml Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. The actual fix was to remove the pipefail, which is not present in any of the other scripts in this file.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 and removed Needs Review A pull request which needs code review. labels May 27, 2026
@kgryte kgryte changed the title chore: fix TypeScript declarations lint errors (issue #11896) chore: fix TypeScript declarations lint errors May 27, 2026
@kgryte kgryte merged commit cb1f5b2 into stdlib-js:develop May 27, 2026
44 checks passed
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix TypeScript declarations lint errors

3 participants