Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ class ProperSuperCallsVisitor extends SimpleAstVisitor<void> {
return false;
}

final expression = statement.expression;
var expression = statement.expression.unParenthesized;
if (expression is AwaitExpression) {
expression = expression.expression.unParenthesized;
}

return expression is MethodInvocation &&
expression.target is SuperExpression &&
Expand Down
48 changes: 48 additions & 0 deletions test/lints/proper_super_calls/proper_super_calls_rule_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,54 @@ class MyWidgetState extends State<StatefulWidget> {
super.initState();
}
}
''',
);
}

void test_no_report_for_async_correct_usage() async {
await assertNoDiagnostics(
r'''
import 'package:flutter/src/widgets/framework.dart';

class MyWidgetState extends State<StatefulWidget> {
@override
Future<void> initState() async {
// ignore: use_of_void_result
await super.initState();
print('');
}

@override
Future<void> dispose() async {
print('');
// ignore: use_of_void_result
await super.dispose();
}
}
''',
);
}

void test_no_report_for_parenthesized_and_async_correct_usage() async {
await assertNoDiagnostics(
r'''
import 'package:flutter/src/widgets/framework.dart';

class MyWidgetState extends State<StatefulWidget> {
@override
Future<void> initState() async {
// ignore: use_of_void_result
await (super.initState());
print('');
}

@override
Future<void> dispose() async {
print('');
// ignore: use_of_void_result
(await super.dispose());
}
}
''',
);
}
Expand Down
Loading