fix: support await expressions in proper_super_calls (#235)#291
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ProperSuperCallsVisitor to correctly handle parenthesized and awaited expressions when checking for proper super calls. It also adds corresponding unit tests to verify that correct usage of async and parenthesized super calls does not trigger diagnostics. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the ProperSuperCallsVisitor to correctly handle parenthesized expressions and AwaitExpressions when verifying super calls. It also adds corresponding unit tests to ensure that correct asynchronous and parenthesized usages do not trigger diagnostics. There are no review comments, so no additional feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Fixes #235