Use bash and pipefail for tests using simple_test_driver.sh - #2083
Open
daviesrob wants to merge 1 commit into
Open
Use bash and pipefail for tests using simple_test_driver.sh#2083daviesrob wants to merge 1 commit into
daviesrob wants to merge 1 commit into
Conversation
A number of tests using this infrastructure run pipelines, so really need pipefail to ensure that all stages have worked correctly. And as pipefail is not supported by all shells, the easiest way to get it is to use bash. All scripts using simple_test_driver.sh are updated even if the tests they run don't use pipelines so they will work without needing updates should a pipeline be added in the future. As bash isn't always installed under /bin, it's also invoked directly from the Makefile so it can be found via PATH. The scripts use directly without having to remember they need bash. Signed-off-by: Rob Davies <rmd+git@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of tests using this infrastructure run pipelines, so really need
pipefailto ensure that all stages have worked correctly. And aspipefailis not supported by all shells, the easiest way to get it is to usebash.All scripts using
simple_test_driver.share updated even if the tests they run don't use pipelines so they will work without needing updates should a pipeline be added in the future. As bash isn't always installed under/bin, it's also invoked directly from the Makefile so it can be found viaPATH. The scripts use directly without having to remember they needbash.