Integrate the reviewed Registry Stack 1.0 changes#469
Conversation
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This reverts commit ca2c60c. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4caaaaf50
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c788d49eb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Maintainer Tier-C source-pack sign-off I reviewed and approve the Tier-C source pack in this PR against the applicable RS-* specifications, including the evidence-versus-programme-decision boundary, Registryctl adopter and smoke contract, disclosure and minimization language, source authority, authorization, and no-match semantics. This sign-off covers the security, trust, and privacy documentation changes in #469. It does not waive the owner-run, independent, or frozen-candidate evidence explicitly left open in the PR description and tracked issues. |
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ec7430b13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| artifact_set = record["candidate_artifact_set"]["artifacts"] | ||
| for field, commit in (("p_release_inputs", source_ref), ("t_release_inputs", target_commit)): | ||
| if artifact_set[field] != release_inputs_sha256(root, commit): |
There was a problem hiding this comment.
Normalize release-input digests before comparing
When a candidate evidence record uses the accepted bare 64-hex spelling for candidate_artifact_set.artifacts.p_release_inputs or t_release_inputs, this exact comparison rejects it because release_inputs_sha256() always returns the sha256:-prefixed form. Other SHA256 coordinates in this validator are normalized before comparison, so otherwise valid upgrade evidence can fail before --require-pass; compare normalized digest strings here.
Useful? React with 👍 / 👎.
Summary
Consolidate the eight reviewed 1.0 implementation PRs into one merge to
main:Every source PR head is retained as an ancestor. The aggregate adds no new product scope. Two additive merge resolutions were required: Registryctl's same-purpose test keeps #462's disclosure/version assertions with #463's renamed claim, and the Notary/Relay changelogs retain both #464 and #465 entries.
This PR supersedes #459 and #462 through #468 so the reviewed 1.0 batch can land through one protected-branch CI and one merge.
Implementer impact
Implementers get one supported Registryctl authoring path, stricter and clearer live-evidence failures, a smaller honest Relay contract, reference-first waiver metadata, explicit adopter evidence templates, and a Debian 13-only maintained tutorial build path.
Checks
Completed locally on the integrated tree:
cargo fmt --all --checkcargo test --locked -p registry-platform-ops -p registry-notary-core -p registry-notary-server -p registry-relay -p registryctlcargo deny check(policy passes; existing unmatched-license, duplicate, and transitivespin 0.9.8yanked warnings remain)python3 -m unittest discover -s release/scripts -p 'test_*.py'(297 tests, 1 environment-dependent skip)python3 release/scripts/check-gates-inventory.py(83 gates)python3 release/scripts/check-debian13-images.pyjust openapi-checkjust openapi-contract origin/mainwith the CI-pinnedoasdiff v1.23.0git diff --checkThe aggregate PR CI is the reference full-workspace, platform, release-source, docs, tutorial, CodeQL, and DCO gate.
Review feedback addressed
sha256:-prefixed artifact coordinate and aggregate-set digests before semantic comparison while retaining strict SHA-256 grammar validation and the exact artifact-set hash. Regression tests cover mixed coordinate spelling and a bare aggregate digest.Security and compatibility review notes
provenance.consentmember. Operators must drain the 15-minute replay window or cleanly re-bootstrap the Relay state plane and must not mix old and updated binaries.Issue status
Closes #417.
Closes #238.
Closes #84.
Closes #362.
Progresses #198, #203, #205, #357, #358, and #380. Their owner-run or immutable-candidate evidence remains required and is not claimed here.
DCO
Signed-off-bytrailer.