Skip to content

Remove inert Relay consent provenance#465

Closed
jeremi wants to merge 5 commits into
mainfrom
agent/relay-consent-provenance
Closed

Remove inert Relay consent provenance#465
jeremi wants to merge 5 commits into
mainfrom
agent/relay-consent-provenance

Conversation

@jeremi

@jeremi jeremi commented Jul 23, 2026

Copy link
Copy Markdown
Member

What changed

  • Remove the inert provenance.consent field from Relay terminal batch payloads, configuration, OpenAPI, and documentation.
  • Reject mixed old/new persisted payloads instead of silently accepting a field with no enforcement semantics.
  • Document the upgrade boundary explicitly: drain retained terminal replays for 15 minutes or perform a clean state-plane rebootstrap; do not mix old and new binaries.

Why

The field looked like a consent control but did not drive authorization or policy. Keeping it created a misleading security surface and extra compatibility burden.

Implementer impact

The Relay contract is smaller and more honest. Operators have one explicit transition procedure rather than a compatibility shim that would preserve ambiguous state.

Validation

  • cargo fmt --check
  • cargo test --locked -p registry-relay
  • just openapi-contract origin/main
  • git diff --check and range diff check

Cargo.lock is unchanged.

Closes #362.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@jeremi
jeremi marked this pull request as ready for review July 23, 2026 13:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c6477bac6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 7541 to 7544
OR NOT (v_terminal -> 'provenance') ?& ARRAY[
'acquired_at', 'source_observed_at', 'source_revision',
'acquisition_class', 'integration', 'consent'
'acquisition_class', 'integration'
]::text[]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate the state-plane attestation fingerprints

When the PostgreSQL state plane is installed or revalidated, this SQL edit changes the attested terminal-payload constraint/function body, but the hard-coded catalog fingerprints and capability helper fingerprint at the top of migration.rs were left at the old values. As a result a clean re-bootstrap creates the reduced shape and then owner_capability_matches calls capability_valid_v1(), which compares the live catalog against the stale constraint/function MD5s and returns CapabilityDrift; existing deployments that run the replacement function hit the same runtime readiness failure. Regenerate/bump the state-plane attestation constants together with this shape change.

Useful? React with 👍 / 👎.

jeremi added 4 commits July 23, 2026 21:36
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This reverts commit ca2c60c.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15363d26d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


## Unreleased

- BREAKING: Remove the inert six-field `provenance.consent` member from the

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the missing DCO sign-off

This commit does not contain any Signed-off-by: trailer, and the DCO workflow scans every PR commit for that trailer before allowing CI to pass, so this PR remains unmergeable until the commit is recreated or amended with a valid sign-off.

AGENTS.md reference: AGENTS.md:L70-L70

Useful? React with 👍 / 👎.

jeremi commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

Superseded by #469, the single ready integration PR for this reviewed 1.0 batch. This PR's exact head is preserved as an ancestor of #469, so its implementation and commit history are retained; only the merge path has been consolidated.

@jeremi jeremi closed this Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide data-use authorization vocabulary before activating the reserved consent slot

1 participant