Skip to content

feat: add resource requests/limits support for cronjobs #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohilsurana merged 1 commit into from
Jul 1, 2026
Merged

feat: add resource requests/limits support for cronjobs #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/app/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.10.2
version: 0.10.3
2 changes: 2 additions & 0 deletions stable/app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ The following table lists the configurable parameters of the Siren chart and the
| cron.jobs[0].args | string | `""` | |
| cron.jobs[0].schedule | string | `"0 0 * * *"` | |
| cron.jobs[0].restartPolicy | string | `Never` | |
| cron.jobs[0].resources | object | `{}` | Per-job resource requests/limits; overrides `cron.resources` when set |
| cron.resources | object | `{}` | Default resource requests/limits applied to every cron job container |
| fullnameOverride | string | `""` | |
| image.pullPolicy | string | `"IfNotPresent"` | Specify the docker image path/repository. |
| image.repository | string | `nil` | |
Expand Down
2 changes: 2 additions & 0 deletions stable/app/templates/cron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ spec:
- name: {{ $job.name }}
image: "{{ $.Values.image.repository }}:{{ $.Values.image.tag | default $.Chart.AppVersion }}"
imagePullPolicy: {{ $.Values.image.pullPolicy }}
resources:
{{- toYaml (default $.Values.cron.resources $job.resources) | nindent 16 }}
command:
{{- toYaml $job.command | nindent 16 }}
args:
Expand Down
5 changes: 5 additions & 0 deletions stable/app/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,18 @@ affinity: {}
cron:
enabled: false
annotations: {}
# -- Default resource requests/limits applied to every cron job container.
# -- Override per job with `cron.jobs[].resources`.
resources: {}
# -- We would recommend to use a small unique job name since it would be used to identify the cronjob in k8s
# -- and job name would be truncated to 29 characters in the cron job template.
jobs:
- name: cronJob1
schedule: "0 0 * * *"
restartPolicy: Never
backoffLimit: 4
# -- Per-job resource requests/limits; overrides `cron.resources` when set.
resources: {}
command:
- app
args:
Expand Down
Loading