feat: add resource requests/limits support for cronjobs#140
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR adds configurable resource requests/limits for cron job containers in a Helm chart. A default 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
The cron job container template doesn't expose
resources, so cron jobs always run with no requests/limits — there's no way to bound their memory/CPU. This adds that support.Changes
cron.jobs[].resources.cron.resourcesis applied to every cron job and can be overridden per job.cron.jobs[].resources→cron.resources→{}.Backward compatibility
Defaults to
{}, which rendersresources: {}— equivalent to the previous no-resources behavior. No change for existing users.Verification
helm lintpasses andhelm templaterenders correctly:cron.resources,resourcesoverrides the default,resources: {}.Chart version bumped
0.10.2→0.10.3; values and README updated.