Skip to content

Regression tests for swadm #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cfzimmerman wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Regression tests for swadm #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
377f650
Delete port-link tests
cfzimmerman Aug 22, 2026
eb6e8e2
Run all --ignored swadm tests in CI
cfzimmerman Aug 22, 2026
7d8eb49
Test utils for CLI validation
cfzimmerman Aug 22, 2026
0435e5d
swadm tx eq tests
cfzimmerman Aug 22, 2026
b1105ea
swadm link apply tests
cfzimmerman Aug 22, 2026
2887c15
Add a README to swadm
cfzimmerman Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/buildomat/packet-test-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,6 @@ DENDRITE_TEST_HOST='[::1]' \
cargo test \
--no-fail-fast \
$SWADM_FEATURES \
--test \
counters \
-- \
--ignored

Expand Down
54 changes: 40 additions & 14 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions swadm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@ reqwest.workspace = true
slog.workspace = true
tabwriter.workspace = true
tokio.workspace = true

[dev-dependencies]
serial_test = "3.5.0"

17 changes: 17 additions & 0 deletions swadm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# SW(itch) ADM(in)

This is the management CLI for Oxide's rack switch.

## Testing

swadm is widely used across scripts and documentation. Changes
should generally be backward compatible.

This is definitionally a string-typed interface, so regressions are
easily missed. The integration tests module has infra for testing
commands, and adding a test before making swadm changes might
help prevent drift.

These tests are run in Linux CI but currently ignored in Illumos CI.
Illumos CI is blocked by tofino simulator support: https://github.com/oxidecomputer/tofino-sde/issues/21

2 changes: 1 addition & 1 deletion swadm/src/link.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ pub enum Link {
/// Whether the link is configured to autonegotiate with its peer during
/// link training.
///
/// This is generally only true for backplane links, and defaults to
/// This is generally only true for backplane links and defaults to false.
#[clap(long)]
autoneg: bool,
/// Whether the link is configured in KR mode, an electrical specification
Expand Down
Loading