Regression tests for swadm - #350
Draft
cfzimmerman wants to merge 6 commits into
Draft
Conversation
cfzimmerman
commented
Aug 22, 2026
The comment mentions a time for deletion, and that time has come. These tests have been ignored in CI for at least a year and reference a CLI command that no longer exists.
The tests CI previously evaded were deleted below.
Decisions: - Use `std::process::Command` and string parsing instead of dpd dropshot endpoints or a --parsable flag. The goal of swadm regression tests is stability on the string typed interface. - But keep this in rust because bash tests would quickly get out of hand. - Keeping utils in the tests dir hopefully atones for putting hideous regexes in swadm.
cfzimmerman
force-pushed
the
cory/ci-tests
branch
3 times, most recently
from
August 24, 2026 19:05
d4fba7d to
542ba2b
Compare
cfzimmerman
force-pushed
the
cory/ci-tests
branch
3 times, most recently
from
August 25, 2026 00:54
de82ad2 to
2887c15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress