Remove fixed UMI-tools seeds and fix UMICollapse jar discovery - #12662
Open
pinin4fjords wants to merge 4 commits into
Open
Remove fixed UMI-tools seeds and fix UMICollapse jar discovery#12662pinin4fjords wants to merge 4 commits into
pinin4fjords wants to merge 4 commits into
Conversation
SPPearce
requested changes
Aug 12, 2026
SPPearce
left a comment
Contributor
There was a problem hiding this comment.
No, I disagree entirely, I think we should be hardcoding random seeds if not specified.
Member
Author
This confuses me. If a tool doesn't set a random seed by default, why should we? The variant you force by setting the seed isn't any more valid than a variant you'd get by setting another one. |
maxulysse
reviewed
Aug 13, 2026
| # The generated launcher allows configuring heap size, but not stack size. | ||
| UMICOLLAPSE_JAR=\$(find "\$(dirname "\$(command -v umicollapse)")/../share" -maxdepth 2 -name umicollapse.jar -print -quit) | ||
|
|
||
| set -o pipefail |
Member
There was a problem hiding this comment.
don't we have that in pipelines' nextflow.config already?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--random-seed=100inumitools/dedupandumitools/groupPYTHONHASHSEED=0in production commandssamtools statssnapshot hashes with current outputRationale
UMI-tools chooses a representative read randomly when duplicate candidates tie. Hard-coding a production seed makes that arbitrary choice repeat without making it robust, and prevents fresh runs from exposing stochastic variability. Users can still request reproducibility by setting
--random-seedthroughtask.ext.args.UMICollapse is packaged with different build suffixes in the existing container and current Bioconda environment. Discovering its JAR within the active installation prefix supports both without pinning the wrapper to a particular package build.
Tests
umicollapse=1.1.0build: JAR discovery and BAM generation passedruff format --checkpassednf-core modules lint umitools/dedup: 61 passed, 3 existing metadata/container warningsnf-core modules lint umitools/group: 57 passed, 3 existing metadata/container warningsnf-core modules lint umicollapse: 60 passed, 1 existing process-label warningnf-core subworkflows lint bam_dedup_stats_samtools_umitools: 32 passednf-core subworkflows lint bam_dedup_stats_samtools_umicollapse: 31 passednf-core subworkflows lint bam_dedup_umi: 33 passed