Skip to content

Deprecate quartonotebook module in favour of quarto/notebook - #12659

Draft
fasterius wants to merge 2 commits into
nf-core:masterfrom
fasterius:quarto/notebook
Draft

Deprecate quartonotebook module in favour of quarto/notebook#12659
fasterius wants to merge 2 commits into
nf-core:masterfrom
fasterius:quarto/notebook

Conversation

@fasterius

Copy link
Copy Markdown
Contributor

This PR deprecates the quartonotebook module in favour of quarto/notebook, since another Quarto-related module has been added (quarto/prerender: #12187).

PR checklist

  • This comment contains a description of changes (with reason).
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

tuple val(meta), path(notebook) , emit: notebook
tuple val(meta), path("params.yml") , emit: params_yaml
tuple val(meta), path("${notebook_parameters.artifact_dir}/*") , emit: artifacts , optional: true
tuple val(meta), path("_extensions") , emit: extensions , optional: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding the versions.yml here too, and having the qmd write it would be useful here too. It adds a useful failure mode that ensures the report writes out versions.

task.ext.when == null || task.ext.when

script:
def deprecation_message = """

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this in the stub too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants