Skip to content

[WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luvs01 wants to merge 1 commit into from
+4 −1
Closed

[WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/redact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const SENSITIVE_KEY_PATTERN = /^(?:authorization|proxy-authorization|cookie|set-
const CREDENTIAL_HEADER_LABEL_RAW = "x-api-key|x-goog-api-key|x-amz-security-token|api[_-]?key|apiKey|access[_-]?token|accessToken|refresh[_-]?token|refreshToken|id[_-]?token|client[_-]?secret|clientSecret|authorization|proxy-authorization|cookie|set-cookie|password|secret|token";

const CREDENTIAL_HEADER_LABEL = CREDENTIAL_HEADER_LABEL_RAW
.replace(/(?<![\[\\])([A-Za-z])(?![\]\-])/g, "[$1\u0001]");
.replace(/[A-Za-z]/g, "[$&\u0001]");

/**
* Characters that render as a colon separator. Folded to `:` in the matching
Expand Down
3 changes: 3 additions & 0 deletions tests/redact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,9 @@ describe("redactSecretString", () => {
'<header name="author&ii;zation">opaquecredential123456</header>',
'<header name="s&ee;cret">opaquecredential123456</header>',
'<header name="passwor&DifferentialD;">opaquecredential123456</header>',
"&chi;-api-key: opaquecredential123456",
"x-ap&iota;-key: opaquecredential123456",
'<header name="&chi;-api-key">opaquecredential123456</header>',
]) {
const redacted = redactSecretString(input);
expect(redacted).toContain(REDACTED_SECRET);
Expand Down
Loading