[WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels - #19
[WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels#19luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
✅ Deterministic PR hygiene checks passed. |
|
Closing this public review surface. The named-entity label bypass is real, but it belongs to a broader credential-redaction review covering attribute framing and token-ordering edge cases. The complete grammar and downstream log/debug regressions are being handled through private security review; this public copy will not receive further updates. |
Motivation
χ-api-keyorx-apι-keyto bypass redaction.Description
\u0001) so every letter position (including hyphen-adjacent ones) accepts named-entity placeholders, and add targeted regression tests forχ-api-key,x-apι-key, and<header name="χ-api-key">intests/redact.test.ts.Testing
bun test tests/redact.test.ts,bun run typecheck,bun run privacy:scan, and the fullbun run test, and all test commands passed.