Skip to content

[WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels - #19

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-html-entity-redaction-bypass
Closed

[WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels#19
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-html-entity-redaction-bypass

Conversation

@luvs01

@luvs01 luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The generated credential-label grammar did not accept the HTML-named-entity placeholder at letter positions immediately adjacent to hyphens, which allowed inputs like χ-api-key or x-apι-key to bypass redaction.

Description

  • Change the credential-label generation to substitute every ASCII letter with a character class that includes the opaque placeholder (\u0001) so every letter position (including hyphen-adjacent ones) accepts named-entity placeholders, and add targeted regression tests for &chi;-api-key, x-ap&iota;-key, and <header name="&chi;-api-key"> in tests/redact.test.ts.

Testing

  • Ran bun test tests/redact.test.ts, bun run typecheck, bun run privacy:scan, and the full bun run test, and all test commands passed.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 35e5e4a9-efa5-4a73-9ea2-1572eb664e15

📥 Commits

Reviewing files that changed from the base of the PR and between 2468502 and 00b87ae.

📒 Files selected for processing (2)
  • src/lib/redact.ts
  • tests/redact.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions github-actions Bot changed the title fix(redact): cover named HTML entities adjacent to hyphens in credential labels [WRONG BRANCH] fix(redact): cover named HTML entities adjacent to hyphens in credential labels Aug 7, 2026
@github-actions
github-actions Bot marked this pull request as draft August 7, 2026 05:41
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 7, 2026

luvs01 commented Aug 7, 2026

Copy link
Copy Markdown
Owner Author

Closing this public review surface. The named-entity label bypass is real, but it belongs to a broader credential-redaction review covering attribute framing and token-ordering edge cases. The complete grammar and downstream log/debug regressions are being handled through private security review; this public copy will not receive further updates.

@luvs01 luvs01 closed this Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant