[Docs] Document connection/credential access control in environments - #1206
Conversation
Supersedes PR #1141. Verified the three access paths against the meshery-cloud implementation (server/dao/connection_access.go) rather than documenting them from the PR description alone: - Direct ownership and Workspace/Team indirect access are both real, but indirect access is read-only - it does not confer delete/modify rights, which the original PR did not distinguish. - Adds the "View All Organizations" key override, a third access path that exists in code but was missing from the original PR. - Drops the original PR's claim that Designs and Views inherit access through the same Workspace/Team chain - they use a separate resource-access-mapping mechanism instead. Leaves identity-and-security/_index.md untouched; the original PR's edit there swapped an em-dash for parentheses, which its own review flagged as an inconsistency, not an improvement. Signed-off-by: miacycle <184569369+miacycle@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe environment documentation now explains access control for Connections and Credentials through ownership, Workspace or Team membership, and the “View All Organizations” key. It also distinguishes access mappings for Designs and Views. ChangesEnvironment access control
Estimated code review effort: 1 (Trivial) | ~3 minutes Mergeability Score: ⚪ Minimal · up to This documentation-only change is localized and merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Acknowledged - no actionable findings from the automated review. |
|
🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1206/
|
Notes for Reviewers
Supersedes and closes #1141.
Description
Adds an Access Control for Connections and Credentials section to
cloud/concepts/spaces/environments.md, documenting the same topic #1141 set out to cover, but verified directly against themeshery-cloudimplementation (server/dao/connection_access.go) rather than written from assumption. Differences from #1141:DeleteUserOwnedConnectionand credential delete/update explicitly do not honor it) - [Docs] Document connection access control in environments #1141 implied it granted full inherited access, including delete.identity-and-security/_index.mduntouched. [Docs] Document connection access control in environments #1141 changed one of its bullets from an em-dash to a parenthetical, which its own review flagged as an inconsistency with the rest of the file rather than an improvement, so that edit isn't carried forward here.Verified locally:
npm install && hugo --gcbuilds cleanly (1604 pages, no broken{{< ref >}}links) and the new section's heading anchor and TOC entry render as expected.Signed commits
Summary by CodeRabbit