[Docs] Document connection access control in environments - #1141
[Docs] Document connection access control in environments#1141YASHMAHAKAL wants to merge 1 commit into
Conversation
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for identity, security, and environments. Specifically, it renames a list item in the identity and security concepts page and adds a new section explaining access control for connections and credentials in the environments page. The review feedback suggests improving consistency by using an em-dash instead of parentheses, using 'User ID' instead of 'UserID' for better readability, and simplifying a wordy sentence describing indirect access.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Preview deployment for PR #1141 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
simihablo
left a comment
simihablo
left a comment
There was a problem hiding this comment.
@rishiraj38, please review. You're working resource access mapping now, right?
|
Thanks for opening this and for identifying that connection/credential access control needed documenting - closing in favor of #1206, which covers the same ground but verifies the described behavior directly against the That check surfaced a few corrections worth calling out: indirect (Workspace/Team) access is read-only rather than full inherited control, there's a third access path via the "View All Organizations" key that wasn't covered here, and Designs/Views turn out to use a separate access-control mechanism rather than the same inheritance chain as Connections/Credentials. #1206 also picks up the unresolved review feedback on this PR (User ID vs UserID, the repeated sentence) and leaves |
Supersedes PR layer5io#1141. Verified the three access paths against the meshery-cloud implementation (server/dao/connection_access.go) rather than documenting them from the PR description alone: - Direct ownership and Workspace/Team indirect access are both real, but indirect access is read-only - it does not confer delete/modify rights, which the original PR did not distinguish. - Adds the "View All Organizations" key override, a third access path that exists in code but was missing from the original PR. - Drops the original PR's claim that Designs and Views inherit access through the same Workspace/Team chain - they use a separate resource-access-mapping mechanism instead. Leaves identity-and-security/_index.md untouched; the original PR's edit there swapped an em-dash for parentheses, which its own review flagged as an inconsistency, not an improvement. Signed-off-by: miacycle <184569369+miacycle@users.noreply.github.com>
3 participants
Description
Adds a new Access Control for Connections and Credentials section to
cloud/concepts/spaces/environments.mdSigned commits