Skip to content

fix(ws): per-instance event loop for same-process multi-Client #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liangxp1990 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ws): per-instance event loop for same-process multi-Client #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions lark_channel/ws/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def __init__(self,
self._conn_url: str = ""
self._service_id: str = ""
self._conn_id: str = ""
self._loop = loop
self._loop = asyncio.new_event_loop() # per-instance loop (was module-level singleton → multi-Client in one process collided with "event loop already running"; align with OpenClaw multi-account)
self._reconnect_task = None
# Local defaults; the Feishu WS endpoint authoritatively replaces these
# via _configure() on every handshake (and may push updates mid-session
Expand Down Expand Up @@ -224,20 +224,20 @@ def __init__(self,

def start(self) -> None:
try:
loop.run_until_complete(self._connect())
self._loop.run_until_complete(self._connect())
except ClientException as e:
logger.error(self._fmt_log("connect failed, err: {}", e))
raise e
except Exception as e:
logger.error(self._fmt_log("connect failed, err: {}", e))
if self._auto_reconnect:
loop.run_until_complete(self._disconnect_and_reconnect())
self._loop.run_until_complete(self._disconnect_and_reconnect())
else:
loop.run_until_complete(self._disconnect())
self._loop.run_until_complete(self._disconnect())
raise e

loop.create_task(self._ping_loop())
loop.run_until_complete(_select())
self._loop.create_task(self._ping_loop())
self._loop.run_until_complete(_select())

async def _ping_loop(self):
while True:
Expand Down Expand Up @@ -276,7 +276,7 @@ async def _connect(self) -> None:
self._service_id = service_id

logger.info(self._fmt_log("connected to {}", conn_url))
loop.create_task(self._receive_message_loop(conn))
self._loop.create_task(self._receive_message_loop(conn))
except InvalidHandshake as e:
_parse_ws_conn_exception(e)

Expand All @@ -295,10 +295,10 @@ async def _receive_message_loop(self, conn):

async def _schedule_handle_message(self, msg) -> None:
if self._handler_semaphore is None:
loop.create_task(self._handle_message(msg))
self._loop.create_task(self._handle_message(msg))
return
await self._handler_semaphore.acquire()
loop.create_task(self._handle_message_with_limit(msg))
self._loop.create_task(self._handle_message_with_limit(msg))

async def _handle_message_with_limit(self, msg) -> None:
try:
Expand Down