fix(ws): per-instance event loop for same-process multi-Client#8
Open
liangxp1990 wants to merge 1 commit into
Open
fix(ws): per-instance event loop for same-process multi-Client#8liangxp1990 wants to merge 1 commit into
liangxp1990 wants to merge 1 commit into
Conversation
ws/client.py used a module-level `loop` singleton (loop = asyncio.get_event_loop() at import). Client.start() did loop.run_until_complete(_select()) which occupied that single loop indefinitely, so a second Client in the same process collided with "This event loop is already running" — making same-process multi-bot impossible (e.g. agno AgentOS multi-bot pattern, OpenClaw-style multi-account). Fix: each Client gets its own loop (self._loop = asyncio.new_event_loop() in __init__) and uses self._loop everywhere (start/_connect/_receive_message_loop/ _schedule_handle_message). Single-Client behavior unchanged; N Clients now coexist in one process, each on its own loop — aligning with OpenClaw (Node) which runs multiple accounts concurrently on one event loop natively. Verified: two FeishuChannel (two app_id) in one agno AgentOS process both connect (running:true), no "event loop already running".
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ws/client.py used a module-level
loopsingleton (loop = asyncio.get_event_loop() at import). Client.start() did loop.run_until_complete(_select()) which occupied that single loop indefinitely, so a second Client in the same process collided with "This event loop is already running" — making same-process multi-bot impossible (e.g. agno AgentOS multi-bot pattern, OpenClaw-style multi-account).Fix: each Client gets its own loop (self._loop = asyncio.new_event_loop() in init) and uses self._loop everywhere (start/_connect/_receive_message_loop/ _schedule_handle_message). Single-Client behavior unchanged; N Clients now coexist in one process, each on its own loop — aligning with OpenClaw (Node) which runs multiple accounts concurrently on one event loop natively.
Verified: two FeishuChannel (two app_id) in one agno AgentOS process both connect (running:true), no "event loop already running".