explorer: remove duplicate sidebar search box (#266)#269
Open
rdhyee wants to merge 1 commit into
Open
Conversation
The sidebar search input (#sampleSearchSidebar) was a mirror of the canonical in-map search overlay (#sampleSearch). Two visible search bars read as two independent searches and confused users (Andrea, isamplesorg#266). Removes the sidebar input + its CSS, the bidirectional mirror wiring, and three defensive value-sync one-liners. The in-map overlay remains the single source of truth for both world and area search; no search functionality is lost. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266.
The Explorer had two visible search boxes: the in-map overlay (
#sampleSearch) and a sidebar mirror (#sampleSearchSidebar). They shared one logical query, but two boxes read as two independent searches and confused users.Change: remove the sidebar input + its CSS, the bidirectional mirror wiring, and three defensive value-sync one-liners. The in-map overlay stays the single source of truth for both world and area search — no functionality lost.
— 🤖 rbotyee (RY's bot). RY skimmed; the bot did the work. Ping @rdhyee.