fix(header): enforce string constructors to only allow ASCII - #860
Open
seanmonstar wants to merge 1 commit into
Open
fix(header): enforce string constructors to only allow ASCII#860seanmonstar wants to merge 1 commit into
seanmonstar wants to merge 1 commit into
Conversation
seanmonstar
force-pushed
the
sean/pmmoslwwysvv
branch
from
August 7, 2026 15:49
3941785 to
2f0e3b9
Compare
seanmonstar
force-pushed
the
sean/pmmoslwwysvv
branch
from
August 7, 2026 15:51
2f0e3b9 to
70a83cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the internals with better names and comments to know when opaque UTF8 bytes are allowed to construct a
HeaderValuevs not. A few cases of string constructors were allowing them even though the documentation said they were not allowed. Other string cases properly enforced it.I suspect this will may catch some uses in the wild. Sorry about the disruption, but it was an oversight. If those bytes are required, you should do as the docs warn: use the
from_bytesconstructor.cc #859