fix(header): reject values with bytes > 127u8 - #859
Open
RyanSquared wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR! I see what you mean. However, the change you suggested affects other constructors too in a way that it shouldn't. Because it's clearly confusing internally, I filed #860 to clear things up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation currently states:
This change limits the upper bound on bytes to 127, making use of RangeInclusive, stable since Rust 1.35.0.
It also allows the tab char (as RFC conformant linear white space). The docs should be amended to mention this as well. I considered it out of scope for this PR.