chore(runner): shared e2e helpers, and a failure report that isn't empty (DEV-2203) - #181
Closed
danielzytohoc wants to merge 2 commits into
Closed
chore(runner): shared e2e helpers, and a failure report that isn't empty (DEV-2203)#181danielzytohoc wants to merge 2 commits into
danielzytohoc wants to merge 2 commits into
Conversation
…pty (DEV-2203) The suite's most-copied code becomes e2e/helpers.ts: stubShell and signIn existed verbatim in nine specs, the session-cleanup pattern in two, the noise filter in one. New DEV-2203 specs import from here; existing specs migrate opportunistically. CI kept uploading runner/playwright-report/ on failure, but the 'github' reporter never writes it — the artifact has been empty since the workflow was added. The html reporter now fills it, and both workflows also upload test-results/ (where traces actually land). fflate joins the root devDependencies so specs can assert on the contents of a downloaded workspace zip (the app already builds them with fflate).
This was referenced Aug 14, 2026
…foundation # Conflicts: # runner/package.json # runner/pnpm-lock.yaml
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the DEV-2203 series (E2E suite for the demo runner, run against production).
What
runner/e2e/helpers.ts— the suite's most-copied code becomes a shared module:stubShellandsignInexisted verbatim in nine specs, the session-cleanup pattern in two, the console-noise filter in one. Also exports the readiness/grid helpers (previewReady,expectGridRendered) built on the documenteddata-preview-statustest contract, andworkspaceFiles()for thewindow.__HOT_FILES__hook that lands with the Style-panel spec PR. New specs import from here; existing specs keep their local copies and migrate opportunistically — a mass rewrite would churn thousands of spec lines for zero behaviour change.githubreporter never writesplaywright-report/, so the on-failure artifact both workflows upload has been empty since they were added. CI now also runs thehtmlreporter, and the workflows uploadtest-results/too (where traces actually land).fflateroot devDependency — so upcoming specs can assert on the contents of a downloaded workspace zip (the app already builds those zips with fflate at the same version).Verification
pnpm build+pnpm typecheck+pnpm test(360 pass) + full deterministicpnpm e2e(152 passed, 124 live-gated skips, 0 failures).Part of DEV-2203; next in the series: share-view, editor/version, engine/docs-frameworks, style-panel specs, then the workflow wiring.
Note
Low Risk
Test infrastructure and CI artifact wiring only; no production app or auth logic changes in this diff.
Overview
Introduces
runner/e2e/helpers.tsas the shared Playwright toolkit for DEV-2203: deterministic shell stubs (stubShell,signIn), editor/preview helpers (activeEditor,workspaceFiles,pickFromMenu,previewReady,expectGridRendered), console noise filtering, and Tier-2trackSessionscleanup. Existing specs are not bulk-migrated; new work imports from here.CI debugging: Playwright in CI now runs the html reporter alongside
listandgithub, because thegithubreporter alone never populatedplaywright-report/.ci.ymlande2e-live.ymlupload bothrunner/playwright-report/andrunner/test-results/(traces) on failure, withif-no-files-found: warn.Adds root
fflatedevDependency for upcoming specs that assert on downloaded workspace zip contents.Reviewed by Cursor Bugbot for commit d7e9481. Bugbot is set up for automated code reviews on this repo. Configure here.