ci: wire the DEV-2203 suites — post-deploy smoke, weekly canary, monthly matrix - #189
Open
danielzytohoc wants to merge 5 commits into
Open
ci: wire the DEV-2203 suites — post-deploy smoke, weekly canary, monthly matrix#189danielzytohoc wants to merge 5 commits into
danielzytohoc wants to merge 5 commits into
Conversation
…hly matrix e2e-live.yml grows three ways in: the manual dispatch it always had (now with ai and pkg_pr_new_ref inputs), a weekly Monday prod canary for external drift (the hosted bundler, npm, the broker, docs-bucket rot — deploy breakage is caught at deploy time, so daily would only buy triage), and a workflow_call smoke mode both deploy workflows now invoke after their curl checks: the @smoke subset, one container, minutes. The full deployed run folds in the specs nothing ever ran (row-striping, preview-recovery's live half, import-live) plus the DEV-2203 additions, split by what they hold: the sandpack/API-read step runs parallel, the container step strictly --workers=1 against the global pool of five, the authed share round-trip treats a rotten E2E_BROKER_TOKEN as a notice rather than a red run, and the AI step runs on the canary or by asking. e2e-starter-matrix.yml gains the monthly sweep (1st, 05:00 UTC) — the only coverage of the full starters × majors surface, at a cadence matched to npm-release timescales. Concurrency keeps deployed runs uncancellable so no run ever strands container sessions.
added 2 commits
August 17, 2026 08:37
The post-deploy smoke boots a live-preview container; an unconditional cancel-in-progress killed the whole run — smoke included — on the next push to master, stranding that session in the global Sandbox pool (cleanup lives in a finally a cancellation never reaches). Deploys now queue, matching deploy-runner-api.yml. The other #189 finding — e2e-live listing style-panel.spec.ts before it existed on this branch — is resolved by linearising the stack: the spec now sits in this branch's ancestry (185 → 186 → 187 → here).
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e958c1. Configure here.
added 2 commits
August 17, 2026 08:45
…ugbot #189) The authed-share step puts a live session JWT in sessionStorage and an Authorization header; a Playwright trace records both, GitHub does not redact secrets inside artifact zips, and this repo is public — so a failed canary would have published a valid @handsontable.com session for seven days. That step now runs with --trace off --retries=0 and scrubs test-results/ and playwright-report/ before the on-failure upload can see them (|| status capture: Actions runs bash -e, so a plain $? after a failing command is unreachable). The monthly starter matrix moves to 03:00 on the 1st: at 05:00 a Monday-the-1st would start it alongside the weekly canary, and matrix --workers=2 plus the canary's serialized container suite against the same global pool of five is exactly the contention both workflow headers warn about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Last in the DEV-2203 stack. Stacked on #187 — merge the stack bottom-up (#181 → #182 → #183 → #184/#185 → #186 → #187 → this).
The coverage layers this creates
@smokeworkflow_call--workers=2, unchanged disciplinee2e-live.yml
ai(LLM answer checks),pkg_pr_new_ref(one real container at a pkg.pr.new build — DEV-2198 validation days).row-striping,preview-recovery's live half,import-live.--workers=1; the authed share step pre-checksE2E_BROKER_TOKENagainst the broker and turns rot into a::warning, not a red run.finally).Notes
runner/AGENTS.mdCI/CD table updated.Note
Medium Risk
Changes deploy concurrency and adds scheduled prod E2E that consume real container pool capacity and LLM budget on the weekly canary; mis-timed crons or cancellation policy regressions could strand Sandboxes or starve live traffic, but no application runtime code changes.
Overview
Adds post-deploy
@smokeE2E to both API and authoring deploy workflows viaworkflow_calltoe2e-live.ymlagainst prod — one container render per engine, share fixture, docs example, and one Style round-trip after health/bundle curls.Authoring deploy turns off
cancel-in-progressso mid-smoke cancellation cannot strand live-preview sessions in the global Sandbox pool.e2e-live.ymlexpands into the full live layer: weekly Monday 05:00 UTC prod canary (with AI),workflow_callsmoke mode, dispatch inputsaiandpkg_pr_new_ref, split steps (parallel Sandpack vs--workers=1container suites), previously orphaned specs (row-striping,import-live, etc.), broker-token-gated authed share with trace scrubbing, and concurrency keyed by mode/smoke run id.e2e-starter-matrix.ymladds monthly cron (1st at 03:00 UTC) with prod fallback when schedule has no inputs, staggered from the weekly canary to avoid competing for five global container slots.runner/AGENTS.mdCI/CD table documents the new triggers and deploy smoke behavior.Reviewed by Cursor Bugbot for commit b62ed73. Bugbot is set up for automated code reviews on this repo. Configure here.