You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @devshahofficial ! Thanks for the PR. Would it be possible to move the plugin into our (plugins directory)[https://github.com/google-deepmind/mujoco/tree/main/plugin] instead?
I try to steer clear of special branches for specific resource loading/file support in user/ when I can.
Thanks @havess, done. I moved the mujoco: asset provider into plugin/resource_provider and removed the special-case registration path from src/user/user_resource.cc.
Quick CI note: the lone macos-15-x86_64 failure looks infra-related rather than code-related. Configure failed while FetchContent was cloning GLFW because the runner could not resolve github.com:
fatal: unable to access 'https://github.com/glfw/glfw.git/': Could not resolve host: github.com
The follow-up artifact upload also failed with ENOTFOUND. I tried rerunning the failed run/job from gh, but GitHub rejected the rerun request, so this likely needs a maintainer-side rerun if the check does not get retried automatically.
Pushed an empty Trigger CI rerun commit because GitHub would not let me rerun the infra-failed macOS job directly. No source changes in this push; just trying to get a clean fresh matrix after the DNS failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #3254 in response to Haroon's request for smaller Filament PRs.
Summary
mujoco:resource provider for packaged runtime assets.assets/.Validation
git diff --checkcmake -S . -B /tmp/mujoco-resource-provider-build -DMUJOCO_BUILD_TESTS=ON -DMUJOCO_TEST_PYTHON_UTIL=OFF -DCMAKE_BUILD_TYPE=Releasecmake --build /tmp/mujoco-resource-provider-build --target user_resource_test -j2/tmp/mujoco-resource-provider-build/bin/user_resource_testfrom the repositorytest/cwdNotes