Skip to content

Package Filament runtime assets#3337

Open
devshahofficial wants to merge 1 commit into
google-deepmind:mainfrom
devshahofficial:devshahofficial/filament-packaging-runtime
Open

Package Filament runtime assets#3337
devshahofficial wants to merge 1 commit into
google-deepmind:mainfrom
devshahofficial:devshahofficial/filament-packaging-runtime

Conversation

@devshahofficial

Copy link
Copy Markdown
Contributor

Split out from #3254 in response to Haroon's request for smaller Filament PRs.

Summary

  • Copies generated Filament .filamat and .ktx assets into Python wheel package data when present.
  • Installs generated Filament runtime assets under ${CMAKE_INSTALL_LIBDIR}/assets.
  • Narrows Linux plugin library matching to shared objects.
  • Makes the classic Python renderer tolerate builds where GLContext is intentionally unavailable.
  • Documents the Linux mixed-stdlib source-build caveat for Studio.

Validation

  • git diff --check
  • python3 -m py_compile python/setup.py python/mujoco/rendering/classic/renderer.py python/mujoco/renderer_test.py
  • cmake -S . -B /tmp/mujoco-packaging-runtime-build -DMUJOCO_BUILD_TESTS=OFF -DMUJOCO_TEST_PYTHON_UTIL=OFF -DCMAKE_BUILD_TYPE=Release
  • cmake --build /tmp/mujoco-packaging-runtime-build --target mujoco -j2

Notes

  • Draft PR: wheel-building with generated Filament assets should still be run in CI / a Filament-enabled environment.

@devshahofficial devshahofficial force-pushed the devshahofficial/filament-packaging-runtime branch from 64f4a8c to d5bed17 Compare June 29, 2026 20:35
@devshahofficial devshahofficial marked this pull request as ready for review June 29, 2026 20:35
@devshahofficial

Copy link
Copy Markdown
Contributor Author

Rebased this onto current main, force-pushed the refreshed branch, and marked it ready for review.

Local validation:

  • git diff --check
  • python3 -m py_compile python/setup.py python/mujoco/renderer_test.py python/mujoco/rendering/classic/renderer.py
  • smoke-tested the new Filament asset setup helper with fake .filamat / .ktx assets, explicit MUJOCO_FILAMENT_ASSETS_DIR, automatic MUJOCO_PATH/lib/assets discovery, and missing-sentinel error handling
  • cmake -S . -B /tmp/mujoco-pr3337-build -DMUJOCO_BUILD_TESTS=ON -DMUJOCO_TEST_PYTHON_UTIL=OFF -DCMAKE_BUILD_TYPE=Release
  • cmake --build /tmp/mujoco-pr3337-build --target mujoco -j2

Fresh CI is running on the rebased commit now.

@devshahofficial

Copy link
Copy Markdown
Contributor Author

@mmossg this is ready as the second piece after #3252. It is scoped to packaging the Filament runtime assets, and the last matrix was green.

I would keep this before #3339 because the resource-provider PR makes more sense once the package asset layout is in. Could you review when you have a minute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants