Skip to content

fix: remove stale detection_rounds from controller #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
godon-robot merged 2 commits into from
Jul 14, 2026
Merged

fix: remove stale detection_rounds from controller #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42804f0
fix: remove stale detection_rounds table creation from controller
godon-robot[bot] Jul 14, 2026
85eaf54
fix: create metadata table before idempotent breeder check
godon-robot[bot] Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions controller/breeder_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ def create_breeder(self, breeder_config, name):
targets_count = len(targets)
is_cooperative = breeder_config.get('cooperation', {}).get('active', False)

# Ensure metadata table exists before querying it (idempotent check)
self.metadata_repo.create_table()

# Check if a breeder with this name already exists.
# If it does, return the existing breeder instead of creating a duplicate
# and dispatching duplicate workers.
Expand Down Expand Up @@ -482,12 +485,6 @@ def create_breeder(self, breeder_config, name):
meta_state=breeder_config
)

# Create detection_rounds table and insert a round for this breeder.
# Each breeder gets a round as sender — breeders coordinate through
# this table: sender impulses, receivers hold still.
self.archive_repo.ensure_detection_rounds_table()
self.archive_repo.insert_detection_round(sender_id=breeder_uuid)

# Launch worker scripts with error handling
worker_launch_failures = []
target_count = 0
Expand Down
Loading