Skip to content

fix(multi-device-docs-tester): Chrome SUID sandbox and server unreachable from agent container#46157

Open
pelikhan with Copilot wants to merge 5 commits into
mainfrom
copilot/multi-device-docs-testing-report-2026-07-17
Open

fix(multi-device-docs-tester): Chrome SUID sandbox and server unreachable from agent container#46157
pelikhan with Copilot wants to merge 5 commits into
mainfrom
copilot/multi-device-docs-testing-report-2026-07-17

Conversation

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

The multi-device docs tester failed every run due to two independent networking/sandbox issues caused by the agent running inside a Docker container while pre-agent steps run on the host runner.

Chrome sandbox SUID (chrome-sandbox mode 0777 → 4755)

Chrome refuses to launch if chrome-sandbox is present but lacks the SUID bit. The runner ships it as 0777; the Docker bind mount preserves whatever mode is set at mount time. Fix: new pre-agent step sets 4755 on the host before the container starts.

- name: Configure Chrome sandbox
  run: |
    if [ -f /opt/google/chrome/chrome-sandbox ]; then
      sudo chmod 4755 /opt/google/chrome/chrome-sandbox
    fi

Docs server unreachable from the agent container (127.0.0.10.0.0.0)

The preview server was bound to 127.0.0.1:4321 (host loopback). Inside the agent container, localhost resolves to the container's own loopback — a different network namespace — so every curl http://localhost:4321/… failed. Two changes:

  • Server bind: --host 127.0.0.1--host 0.0.0.0
  • Agent prompt: all localhost:4321 references → host.docker.internal:4321 (same pattern used by daily-byok-ollama-test)

The pre-agent TCP readiness check retains 127.0.0.1 since that step runs on the host.

Copilot AI and others added 2 commits July 17, 2026 07:20
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…e docs tester

- Add pre-agent step to set chrome-sandbox SUID mode (4755) before container starts
- Bind docs preview server to 0.0.0.0 so it's reachable from the agent container
- Update agent prompt to use host.docker.internal:4321 instead of localhost:4321

Fixes #46149

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix multi-device validation errors for testing report fix(multi-device-docs-tester): Chrome SUID sandbox and server unreachable from agent container Jul 17, 2026
Copilot AI requested a review from pelikhan July 17, 2026 07:34
@pelikhan
pelikhan marked this pull request as ready for review July 17, 2026 08:31
Copilot AI review requested due to automatic review settings July 17, 2026 08:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Chrome startup and host-served documentation access from the sandboxed agent container.

Changes:

  • Configures Chrome’s SUID sandbox before agent startup.
  • Exposes Astro on all interfaces and uses host.docker.internal.
  • Regenerates workflow lock files and action metadata.
Show a summary per file
File Description
.github/workflows/daily-multi-device-docs-tester.md Applies sandbox and networking fixes.
.github/workflows/daily-multi-device-docs-tester.lock.yml Compiles the workflow changes.
.github/workflows/skillet.lock.yml Refreshes generated action metadata.
.github/workflows/release.lock.yml Refreshes generated action metadata.
.github/workflows/hourly-ci-cleaner.lock.yml Refreshes generated action metadata.
.github/workflows/avenger.lock.yml Refreshes generated action metadata.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Medium

@pelikhan pelikhan added the awf label Jul 17, 2026
@pelikhan

Copy link
Copy Markdown
Collaborator

@lpcox review please

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address unresolved review feedback, investigate any failed checks listed below, refresh the branch if needed, and rerun checks once ready.

Generated by pr-sous-chef: https://github.com/github/gh-aw/actions/runs/29590499747

Generated by 👨‍🍳 PR Sous Chef · 8.3 AIC · ⌖ 10.9 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address unresolved review feedback, investigate any failed checks listed below, refresh the branch if needed, and rerun checks once ready.

Generated by ...

Done. Here's the summary:

  • Reviews — No unresolved review threads on this PR.
  • Checks (local)make fmt, make lint, make test-unit, and make recompile all pass. Recompile produced an update to smoke-call-workflow.lock.yml which has been committed.
  • Checks (CI) — Stale after agent push; needs human re-trigger. Prior CI run (29563473612): all 22 checks passed.
  • Mergeable — PR is open, not draft, not behind, no conflicts.

Hand-off: CI must be re-triggered by a maintainer (close/reopen PR or push) before merge.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill on #46157, confirm the branch is still up to date, and summarize any remaining maintainer action after checks are re-triggered.

Generated by 👨‍🍳 PR Sous Chef · 14.9 AIC · ⌖ 6.23 AIC · ⊞ 6K ·
Comment /souschef to run again

Copilot AI commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill on #46157, confirm the branch is still up to date, and summarize any remaining maintainer action after checks are re-triggered.

...

Branch confirmed up to date (4 commits ahead of base, no conflicts with main). Local validation all green:

  • Reviews — No unresolved review threads.
  • Checks (local)make fmt, make lint, make test-unit all pass. Working tree is clean.
  • Checks (CI) — Stale on current HEAD (6c381cd); no CI run has executed against it yet. Prior CI on the previous HEAD passed all 22 checks. Needs a human re-trigger.
  • Mergeable — PR is open, not draft, mergeable_state: unstable (pending CI only, no conflicts).

Hand-off: A maintainer needs to re-trigger CI (close/reopen PR or push) and then approve to merge.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill on #46157, confirm the branch is up to date, and hand back the next concrete maintainer action.

Generated by 👨‍🍳 PR Sous Chef · 3.87 AIC · ⌖ 6.21 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill on #46157, confirm the branch is up to date, and hand back the next concrete maintainer action.

...

Branch is still up to date. No changes since last check.

  • Reviews — No unresolved review threads.
  • Checks (local) — Previously confirmed green (make fmt, make lint, make test-unit).
  • Checks (CI) — No CI has run on current HEAD 6c381cd. Needs a human re-trigger.
  • Mergeable — Open, not draft, no conflicts.

Next concrete maintainer action: close and reopen the PR (or push a no-op commit) to trigger CI, then approve and merge once checks pass.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 3.64 AIC · ⌖ 7.92 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

...

Branch is up to date. Local validation passes (make fmt, make lint, make test-unit all green, working tree clean).

  • Reviews — No unresolved review threads.
  • Checks (local) — All pass on HEAD bfc7ef2.
  • Checks (CI) — No CI has run on current HEAD; agent pushes don't trigger workflows. Needs a human re-trigger.
  • Mergeable — Open, not draft, no conflicts with main.

Next maintainer action: re-trigger CI (close/reopen PR or push), then approve and merge once checks pass.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actions/runs/29654427038

Generated by 👨‍🍳 PR Sous Chef · 6.34 AIC · ⌖ 5.58 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Generated by PR Sous Chef: https://github.com/github/gh-aw/actio...

No changes since the last run. Branch is up to date on HEAD bfc7ef2, local validation is green, and there are no unresolved review threads.

The only remaining action is for a maintainer to re-trigger CI (close/reopen the PR or push from a maintainer account), then approve and merge once checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔍 Multi-Device Docs Testing Report - 2026-07-17

4 participants