Skip to content

fix(auth): allow SAML providers in AuthUIConfiguration #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demolaf wants to merge 2 commits into
base: version-10.0.0-beta03
Choose a base branch
from
+19 −4
Open

fix(auth): allow SAML providers in AuthUIConfiguration #2331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dcb024
fix(auth): allow saml. prefixed provider IDs in AuthUIConfiguration v…
demolaf Jun 5, 2026
7f56eb5
updates
demolaf Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions auth/src/main/java/com/firebase/ui/auth/configuration/AuthUIConfiguration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,12 @@ class AuthUIConfigurationBuilder {
"At least one provider must be configured"
}

// No unsupported providers (allow predefined providers and custom OIDC providers starting with "oidc.")
// No unsupported providers (allow predefined providers and custom OIDC/SAML providers)
val supportedProviderIds = Provider.entries.map { it.id }.toSet()
val customPrefixes = listOf("oidc.", "saml.")
val unknownProviders = providers.filter { provider ->
provider.providerId !in supportedProviderIds && !provider.providerId.startsWith("oidc.")
provider.providerId !in supportedProviderIds &&
customPrefixes.none { provider.providerId.startsWith(it) }
}
Comment thread
demolaf marked this conversation as resolved.
require(unknownProviders.isEmpty()) {
"Unknown providers: ${unknownProviders.joinToString { it.providerId }}"
Expand Down
17 changes: 15 additions & 2 deletions auth/src/test/java/com/firebase/ui/auth/configuration/AuthUIConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ class AuthUIConfigurationTest {
}

@Test
fun `validation accepts custom OIDC providers`() {
fun `validation accepts custom OIDC and SAML providers`() {
val linkedInProvider = AuthProvider.GenericOAuth(
providerName = "LinkedIn",
providerId = "oidc.linkedin",
Expand All @@ -348,17 +348,30 @@ class AuthUIConfigurationTest {
contentColor = null,
)

val samlProvider = AuthProvider.GenericOAuth(
providerName = "Corp SSO",
providerId = "saml.corp-sso",
scopes = listOf(),
customParameters = mapOf(),
buttonLabel = "Sign in with Corp SSO",
buttonIcon = null,
buttonColor = null,
contentColor = null,
)

val config = authUIConfiguration {
context = applicationContext
providers {
provider(linkedInProvider)
provider(oktaProvider)
provider(samlProvider)
}
}

assertThat(config.providers).hasSize(2)
assertThat(config.providers).hasSize(3)
assertThat(config.providers[0].providerId).isEqualTo("oidc.linkedin")
assertThat(config.providers[1].providerId).isEqualTo("oidc.okta")
assertThat(config.providers[2].providerId).isEqualTo("saml.corp-sso")
}

@Test
Expand Down
Loading