fix(auth): allow SAML providers in AuthUIConfiguration#2331
Open
demolaf wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for custom SAML providers (prefixed with "saml.") in the AuthUIConfiguration class and updates the corresponding unit tests to verify this behavior. The review feedback suggests refactoring the provider validation logic by extracting the custom provider prefixes into a list and using none to check them, which improves code maintainability and extensibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider ID allowlist only permitted oidc.-prefixed IDs for custom providers via GenericOAuth. This adds
saml.to the same check so Firebase SAML providers (e.g.saml.corp-sso) pass validation rather than being rejected as unknown.